BUG: make ipmt return nan for per < 1
#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in the the docs the period count starts at 1, so `per < 1` doesn't make sense. The change also agrees with the results of Google Sheet's IPMT. Closes numpygh-17.
Kai-Striega
reviewed
Oct 29, 2019
| ipmt = np.where(np.logical_and(when == 1, per == 1), 0, ipmt) | ||
| except IndexError: | ||
| pass | ||
| ipmt = np.array(_rbl(rate, per, total_pmt, pv, when) * rate) |
There was a problem hiding this comment.
Here and below the logic looks good to me. Having the extra comments is also appreciated. 👍
numpy_financial/_financial.py
Outdated
| if isinstance(entry, Decimal): | ||
| return Decimal(value) | ||
| else: | ||
| return value |
There was a problem hiding this comment.
nit: should value here be case to the same dtype as entry?
Not here-was planning on refactoring the tests for |
|
Merged, thanks @person142! 👍 To the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the the docs the period count starts at 1, so
per < 1doesn't make sense. The change also agrees with the results of Google
Sheet's IPMT.
Closes gh-17. Note that the suggested fix there appears to be
incorrect-returning
0forwhen = 'begin'andper = 1shouldbe the correct behavior as no interest has accrued at the beginning
of the first period. (Returning 0 also agrees with IPMT.)