TST: clean up ppmt tests
#27
Conversation
- Move them into their own class - Add tests for invalid `per` arguments
| from decimal import Decimal | ||
| import math |
There was a problem hiding this comment.
Just to confirm, this is to use math.isnan which works for Nan values from both decimal and numpy?
|
@person142 I'm happy with the changes as they are. Would you like to add any extra changes or are you happy for me to merge? Also, I lost track of this while working on something else (sorry!), if that happens in the future feel free to remind me and I'll try to move it up on my list of priorities. |
Let me improve that broadcasting test over the weekend. I’ve been meaning to do it but have been short on time. |
|
@person142 I'm going to merge these changes as they are and open an issue for the broadcasting issue. Thanks for taking the time to neaten the tests so far, I do think it's heading in the right direction. |
In particular,
perargumentsFirst mentioned in #22.