Skip to content

Conversation

saulshanabrook
Copy link
Contributor

Jupyter Book has a conda forge package, so it can be installed from there instead of pip, to help with dependency resolution.

Jupyter Book has a conda forge package, so it can be installed from there instead of pip, to help with dependency resolution.
Copy link
Collaborator

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it turns out that jupyter-book isn't a dependency at all - the dependencies for building the site are listed in site/requirements.txt. Would you mind updating the environment.yml to use those instead?

I suspect the environment.yml has gotten out-of-date because it isn't used/tested anywhere. We should probably add a CI job for that...

@saulshanabrook
Copy link
Contributor Author

@rossbar, sure I can do that.

@saulshanabrook
Copy link
Contributor Author

@rossbar done!

Copy link
Collaborator

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @saulshanabrook , LGTM!

@rossbar rossbar merged commit f08ae45 into numpy:main Feb 8, 2022
@saulshanabrook saulshanabrook deleted the patch-1 branch February 8, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants