DOC: Add warning/clarification about backwards compat in NEP-18 #11943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
commented
Sep 13, 2018
|
|
||
| - For a single major release, NumPy should check for ``__array_function__`` | ||
| methods that implement the given function, followed by checks for the new | ||
| protocol. If any argument returns a value other than ``NotImplemented`` |
There was a problem hiding this comment.
Probably the order of these checks should be reversed. That would let you add __array_new_protocol__ while maintaining __array_function__ for supporting old versions of NumPy without any warnings.
eric-wieser
approved these changes
Sep 14, 2018
|
Merging for now to update the rendered NEP. I'm still happy to make revisions in follow-on PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per mailing list discussion in:
https://mail.python.org/pipermail/numpy-discussion/2018-August/078493.html