MAINT: Add functions to parse shell-strings in the platform-native way #13026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are places in distutils where we accept a single string from the user, and interpret it as a set of command line arguments. Previously, these were passed on as a string unmodified to exec_command, and interpreted by subprocess in a platform-specific way. Recent changes to distutils now pass a list of arguments to subprocess, meaning we have to split the strings ourselves. While `shlex.split` is perfect on posix systems, it is not a good approximation of either the old or the expected behavior on windows. Provides the building blocks needed to fix numpygh-12979
charris
added
00 - Bug
06 - Regression
component: numpy.distutils
08 - Backport
|
Aw crap, I screwed that up. Will undo. Forgot that the branch was still in use, so I couldn't repurpose it for the next PR. |
eric-wieser
force-pushed
the
distutils-windows-split
branch
from
a290dd8 to
77aee9c
Compare
|
Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13023.
There are places in distutils where we accept a single string from the user, and interpret it as a set of command line arguments.
Previously, these were passed on as a string unmodified to exec_command, and interpreted by subprocess in a platform-specific way.
Recent changes to distutils now pass a list of arguments to subprocess, meaning we have to split the strings ourselves.
While
shlex.splitis perfect on posix systems, it is not a good approximation of either the old or the expected behavior on windows.Provides the building blocks needed to fix gh-12979