Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: further fixup to histogram2d dispatcher. #14046

Merged
merged 1 commit into from
Jul 18, 2019
Merged

BUG: further fixup to histogram2d dispatcher. #14046

merged 1 commit into from
Jul 18, 2019

Conversation

charris
Copy link
Member

@charris charris commented Jul 17, 2019

Backport of #13813 .

Now with tests....

@charris charris added this to the 1.16.5 release milestone Jul 17, 2019
@charris
Copy link
Member Author

charris commented Jul 18, 2019

@shoyer This is against the 1.16.x branch. Python 2.7 doesn't dispatch on the arguments with __array_function__, Python 3 works fine. Any idea of why that may be? It isn't functools, I've tried the Python 3 versions.

I'm tempted to just note that __array_function__ is broken on python 2 and leave it at that.

@charris
Copy link
Member Author

charris commented Jul 18, 2019

Oh... Duh. That works a charm. Thanks @shoyer .

@charris charris merged commit 354410f into numpy:maintenance/1.16.x Jul 18, 2019
@charris charris deleted the backport-13813 branch July 18, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoyer shoyer shoyer left review comments

Assignees
No one assigned
Labels
00 - Bug 08 - Backport Used to tag backport PRs component: __array_function__
Projects
None yet
Milestone
1.16.5 release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charris @shoyer @mhvk