BUG: fix inconsistent axes ordering for axis in function unique
#14255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
changed the title
uniqueunique
|
Hmm, I assume that this changes the current behavior. Is it documented anywhere? |
|
Should I add something in docstring？ |
|
I think it aligns the behaviour wrt. sorting with the current documentation? So if we assume that the sort order was too strange to rely on, release notes should be sufficient, I think. |
mattip
reviewed
Sep 12, 2019
improve release note according to review
|
Thanks for the ping and thanks @hgt312! Yes, I think this can go in. It does indeed change behaviour, but the previous behaviour returned unexpected sorting (in odd corner cases), so as I said, I think this should be fine. If anyone seriously disagress, just say so. |
|
Ah, shit, should have squashed :(, oh well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uniquehas is consistent axes order (except the chosen one) whenaxisis notNonenow.Details in #14244.
Change
Using
moveaxisinstead ofswapaxeswhen implementation, so that the orderingof axes except the axis in arguments will not be broken.