DEP: Deprecate load/dump functions in favour of pickle methods #14256
Conversation
numpy/ma/core.py
Outdated
|
|
||
| """ | ||
| # NumPy 1.15.0, 2017-12-10 | ||
| warnings.warn( |
There was a problem hiding this comment.
There is the _pickle_warn function, which was handling the current DeprecationWarning, I think you may have missed it.
There was a problem hiding this comment.
So, I should remove _pickle_warn or warnings.warn?
I introduced the latter since this was consistent in all the deprecated functions I've seen so far.
There was a problem hiding this comment.
The warning was already in place since a long time. You can just remove these functions entirely I think. After your change, there would be two warnings given.
charris
added
07 - Deprecation
component: numpy._core
component: numpy.ma
mattip
removed
the
56 - Needs Release Note.
|
LGTM. @seberg is the formatting of the release note correct (first line beigns with a |
|
To be discussed. My plan is to not worry about it too much and allow both (it is easy to fix it up later) . I thought we used bullet points for these expired deprecations previously, but the fact is, that Chuck always added them later on. Anyway: My plan is to change towncrier, that it does not add the bullets automatically, and then sort bullet points to the front of each section, so that it renders OK even if we end up with mixed style release notes. |
|
Thanks @kritisingh1 |
Related to #11521