Skip to content

MAINT: clean up pocketfft modules inside numpy.fft namespace. #14456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2019
Merged

MAINT: clean up pocketfft modules inside numpy.fft namespace. #14456

merged 2 commits into from
Sep 8, 2019

Conversation

charris
Copy link
Member

@charris charris commented Sep 8, 2019

Backport of #14452.

Follow-up to #14436 (comment)

  • pocketfft.py --> _pocketfft.py
  • pocketfft.c --> _pocketfft.c
  • pocketfft_internal.so --> _pocketfft_internal.so

Also get rid of an old-style info.py file with just a module docstring in it.

@rgommers @charris
MAINT: move pocketfft .py/.so to _pocketfft
15eb36d 
These aren't public, and should have been added with underscores.
@rgommers @charris
MAINT: clean up numpy/fft/info.py
b6408d8
@charris charris added this to the 1.17.3 release milestone Sep 8, 2019
@charris charris merged commit d66c64a into numpy:maintenance/1.17.x Sep 8, 2019
@charris charris deleted the backport-14452 branch September 8, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance 08 - Backport Used to tag backport PRs component: numpy.fft
Projects
None yet
Milestone
1.17.3 release
Development

Successfully merging this pull request may close these issues.
2 participants
@charris @rgommers