DEP: deprecate financial functions. #14720
Conversation
WarrenWeckesser
force-pushed
the
dep-fin
branch
from
9ee5dc0
to
ac2bbe8
Compare
WarrenWeckesser
force-pushed
the
dep-fin
branch
from
ac2bbe8
to
c38fc91
Compare
numpy/lib/financial.py
Outdated
| def _pmt_dispatcher(rate, nper, pv, fv=None, when=None): | ||
| warnings.warn('pmt is deprecated and will be removed from NumPy 1.20.', | ||
| DeprecationWarning, stacklevel=3) | ||
| return (rate, nper, pv, fv) |
There was a problem hiding this comment.
@shoyer: Is the dispatcher the right place for this? What if array_function is disabled via the env var (if that still exists)?
There was a problem hiding this comment.
FWIW: This is how asscalar is deprecated:
Line 551 in 1185880
There was a problem hiding this comment.
That seems to answer the question and looks fine. @shoyer did that asscalar deprecation in the same way says git blame.
What if
array_functionis disabled via the env var (if that still exists)?
That only still exists as an escape hatch in case of unexpected issues with the mechanism, it shouldn't be used otherwise. No need to worry about that I'd say, since even if it is used the impact is very minor.
WarrenWeckesser
force-pushed
the
dep-fin
branch
from
c38fc91
to
9355175
Compare
As per NEP-32, the financial functions are deprecated.
WarrenWeckesser
force-pushed
the
dep-fin
branch
from
9355175
to
6a3dc5d
Compare
rgommers
changed the title
|
Merged, thanks @WarrenWeckesser! |
As per NEP-32, the financial functions are deprecated.