Skip to content

DEP: Deprecated ndindex.ndincr #17233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2020
Merged

DEP: Deprecated ndindex.ndincr #17233

merged 1 commit into from
Sep 3, 2020

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Sep 3, 2020 •
edited
Loading

The "do not use" comment has been here since bb0e4f3. (#393)

@eric-wieser
DEP: Deprecated ndindex.ndincr
92170a8 
The "do not use" comment has been here since bb0e4f3.
@seberg
Copy link
Member

seberg commented Sep 3, 2020

Deprecating ndindex.ndinc() to ask users to use next(ndindex) seems clearly fine to me, its just obscure and easy to fix. Thanks Eric!

@seberg seberg merged commit 925f838 into numpy:master Sep 3, 2020
@seberg
Copy link
Member

seberg commented Sep 3, 2020 •
edited
Loading

Hmm, maybe a bit quick, but it seemed super trivial, I am happy to add a deprecation test case if anyone feels its better.

EDIT: And yes, I saw that I merged it in the future ;) (the date is off by 6 days)

@seberg seberg added the 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified. label Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
07 - Deprecation 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-wieser @seberg