Skip to content

Conversation

pearu
Copy link
Contributor

@pearu pearu commented Mar 29, 2021

Closes #18403

@charris
Copy link
Member

charris commented Mar 30, 2021

LGTM, just a naming nit.

@pearu pearu force-pushed the gh-18403-abstract-interface branch from 3c273cd to c089e9c Compare March 31, 2021 08:25
@pearu pearu requested a review from charris March 31, 2021 08:40
@pearu pearu force-pushed the gh-18403-abstract-interface branch from c089e9c to 8336e76 Compare March 31, 2021 09:02
@pearu
Copy link
Contributor Author

pearu commented Mar 31, 2021

codecov/patch failure is not related to the changes in this PR.

@charris charris merged commit 6113ec7 into numpy:main Mar 31, 2021
@charris
Copy link
Member

charris commented Mar 31, 2021

Thanks Pearu.

@charris charris added 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes and removed 58 - Ready for review labels Mar 31, 2021
@charris charris removed the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Mar 31, 2021
charris added a commit to charris/numpy that referenced this pull request Mar 31, 2021
@pearu pearu deleted the gh-18403-abstract-interface branch April 1, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when parsing fortran code with abstract interface
2 participants