Skip to content

MAINT, TYP: Fix np.angle dtype-overloads #22031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2022
Merged

MAINT, TYP: Fix np.angle dtype-overloads #22031

merged 1 commit into from
Jul 24, 2022

Conversation

charris
Copy link
Member

@charris charris commented Jul 24, 2022

Backport of #21974.

Closes #21972

There were two issues with the previous np.angle annotations:

  • It assumed that all array-likes would be reduced to scalars.
  • It did not take into account that complex dtypes would be coerced into their float-based equivalent.

@charris charris added this to the 1.23.2 release milestone Jul 24, 2022
@charris charris closed this Jul 24, 2022
@charris charris reopened this Jul 24, 2022
@charris charris merged commit 387fadf into numpy:maintenance/1.23.x Jul 24, 2022
@charris charris deleted the backport-21974 branch July 24, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance 08 - Backport Used to tag backport PRs 41 - Static typing
Projects
None yet
Milestone
1.23.2 release
Development

Successfully merging this pull request may close these issues.
2 participants
@charris @BvB93