MAINT,TYP: Add object-overloads for the np.generic
rich comparisons
#22034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #21984.
Closes #21939
An overload was previously missing for object-based rich comparisons of the
np.generic
subclasses.As object array-likes are notoriously difficult to type, the new overload simply checks whether the right operand supports
__gt__
or__lt__
even though this will, in practice, be a bit too broad (e.g. it allowsnp.int64(1) > "test"
to pass).