Skip to content

Conversation

seiko2plus
Copy link
Member

closes #21920

@seiko2plus seiko2plus force-pushed the issue_21920 branch 4 times, most recently from eefc707 to fbabd45 Compare August 18, 2022 20:34
@seiko2plus seiko2plus marked this pull request as ready for review August 18, 2022 20:35
@seiko2plus seiko2plus added 00 - Bug component: SIMD Issues in SIMD (fast instruction sets) code or machinery 36 - Build Build related PR 09 - Backport-Candidate PRs tagged should be backported labels Aug 18, 2022
@seiko2plus seiko2plus force-pushed the issue_21920 branch 2 times, most recently from 8dba91c to 32a4c4c Compare August 18, 2022 21:25
@charris
Copy link
Member

charris commented Aug 18, 2022

@rgommers What is the oldest gcc SciPy is going to support?

@rgommers
Copy link
Member

@rgommers What is the oldest gcc SciPy is going to support?

We bumped it from GCC 4.9 to GCC 8 for the next release: https://github.com/scipy/scipy/blob/0fc5126bf0cfd7d0f46c845003e0c52094d4019b/meson.build#L27-L37

The change in this PR is consistent with what we discussed in the developer meeting. From the meeting notes: GCC versions: we need to test with a wider range of compilers, and drop older compilers. Sayed would like GCC 9, that’s stable for AVX512/SkylakeX features. Also influenced by C++ code. We need C99 and C++11. Proposal: minimum version gcc 6.3 and error out if the compiler is older.

I think GCC 8 would be fine, but doing 6.3 now and waiting if there's major complaints for SciPy before following suit is also fine.

Given that GCC 6 is mainly kept for Ubuntu LTS and that has 6.5
when you install gcc-6 with `apt`, let's document that as the
minimum version (also that is what is tested in CI).

[ci skip]
@rgommers
Copy link
Member

but doing 6.3 now and waiting if there's major complaints for SciPy before following suit is also fine.

Given that what we get from Ubuntu is 6.5, let's make that the documented minimum version. I added a commit that updates the docs in two places to state this.

@rgommers rgommers added this to the 1.24.0 release milestone Aug 19, 2022
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @seiko2plus!

This should be backported to 1.23.3, and it would be good to add it to those release notes.

@charris charris merged commit 555c07f into numpy:main Aug 19, 2022
@charris
Copy link
Member

charris commented Aug 19, 2022

Thanks @seiko2plus .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 - Maintenance 36 - Build Build related PR component: SIMD Issues in SIMD (fast instruction sets) code or machinery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Build of numpy 1.23.0 fails on debian-stretch
4 participants