DEP: Finalize MachAr and machar deprecations #22638
Conversation
numpy/core/__init__.py
Outdated
| @@ -153,13 +152,13 @@ def _DType_reduce(DType): | |||
|
|
|||
|
|
|||
| def __getattr__(name): | |||
| # Deprecated 2021-10-20, NumPy 1.22 | |||
| if name == "machar": | |||
| # Deprecated 2022-11-21, NumPy 1.24. | |||
There was a problem hiding this comment.
Hah, fine, maybe makes life easier for Numba (or it doesn't because for them the other one matters)...
This removes the attributes on finfo and the "public" module. It also deprecates `np.core.MachAr`. We should be able to get away with just deleting it, but there seems little reason to not just deprecate it for now.
|
Not sure what is going on with circleci here, but it looks related :) |
|
The FutureWarnings are new (annoying but the doc build doesn't fail on them). I think either the job ran at a weird time with respect to branching, or the update to 1.25 development, is missing to indlude the new release notes. |
|
Ran through now, I hope it was just weird timing or caching with branching and updating that or so... |
|
It is showing up in other PRs, so not a timing oddity. The release notes are correctly linked, the error message itself is emitted from |
|
My guess is a caching problem. |
|
Well, this is going through and I just restarted the last few jobs. Hopefully, that is all we see from this. |
|
Thanks Sebastian. |
This removes the attributes on finfo and the "public" module. It also deprecates
np.core.MachAr. We should be able to get away with just deleting it, but there seems little reason to not just deprecate it for now.