Skip to content

Adding examples of round to round_ for issue 22266. #24002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Adding examples of round to round_ for issue 22266. #24002

wants to merge 1 commit into from

Conversation

MohitKumar020291
Copy link
Contributor

The changes focuses on adding docstring examples to round_ function of issue #22266.

@MohitKumar020291 MohitKumar020291 mentioned this pull request Jun 21, 2023
Closed
16 tasks
@seberg
Copy link
Member

seberg commented Jun 21, 2023

Thank you, but sorry going to close this. The issue probably shouldn't have listed round_, but by now round_ is actually deprecated and adding examples to a deprecated function isn't helpful unfortunately; also because it may collide with some doctesting work in gh-23812.

@seberg seberg closed this Jun 21, 2023
@MohitKumar020291
Copy link
Contributor Author

@seberg I understand what you said. Thanks for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MohitKumar020291 @seberg