ENH: DType API slot for descriptor finalization before array creation #24988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
force-pushed
the
unique-array-descr
branch
from
3cf9b43 to
d22e73f
Compare
seberg
reviewed
Oct 27, 2023
ngoldbaum
force-pushed
the
unique-array-descr
branch
from
dc5f475 to
7528511
Compare
ngoldbaum
changed the title
|
Updated the description and title to reflect the API discussed above. |
ngoldbaum
force-pushed
the
unique-array-descr
branch
3 times, most recently
from
d095654 to
3d454ee
Compare
|
I think this is ready now - do you think the changes to |
seberg
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Yes, I think this is fine and happy to merge it. One error check missing. Since the take/indexing paths cannot have subarray dtypes, all is good there: in fact, it might fix bugs around S0 string dtypes which can be created in some places (although there may be a point that we should fix that in a lower way using the new hook :)).
ngoldbaum
force-pushed
the
unique-array-descr
branch
from
3d454ee to
a7aa6a3
Compare
seberg
reviewed
Oct 31, 2023
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
|
Thanks for giving this a look @seberg! Let's pull this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new DType API slot,
NPY_DT_finalize_descrthat, when defined, numpy calls before creating a new array buffer and sets the dtype for the array to the return value.In addition to the change to
PyArray_NewFromDescr_Int, this also includes two changes to the boolean subscripting internals andnpy_fasttake, where numpy assumes that input and output dtypes are the same. These are separate bugfixes but were needed to get my stringdtype arena allocator implementation working (numpy/numpy-user-dtypes#92).