Skip to content

Conversation

WarrenWeckesser
Copy link
Member

[skip actions] [skip azp] [skip cirrus]

@charris charris merged commit 890a494 into numpy:main Aug 2, 2024
5 checks passed
@charris
Copy link
Member

charris commented Aug 2, 2024

Thanks Warren.

@WarrenWeckesser WarrenWeckesser deleted the gh27076-dep-note branch August 2, 2024 12:30
@WarrenWeckesser
Copy link
Member Author

In the note that I added, I included a couple extra spaces at the beginning of each line, because that is what I saw in 26452.deprecation.rst. But 26268.expired.rst and 26611.expired.rst don't have the extra indentation. You can see the difference in the rendered release notes: https://output.circle-artifacts.com/output/job/b4498da5-8a6c-4d33-a918-76400e056f83/artifacts/0/doc/build/html/release/2.1.0-notes.html#deprecations

I think extra indentation shouldn't be used. If y'all agree, I'll submit a PR to fix 26452.deprecation.rst and 27076.deprecation.rst.

@WarrenWeckesser
Copy link
Member Author

After looking at the rendering of all the notes, I think it is better to never indent the bullets. Indenting creates a shaded area with a dark bar on the left, and I see no reason for that. I'll submit a PR to fix the notes that have the extra indentation.

@seberg
Copy link
Member

seberg commented Aug 2, 2024

Yes, indeed. None of the bullets shoul be indented. They are just pasted verbatim into the final rst (with the link added below).
(The main special handling is, that bullets are sorted to come before subsections.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants