MAINT: Start applying ruff/flake8-comprehensions rules (C4) #27296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also has linting errors! (So I didn't review yet) |
|
The linting errors are |
|
Probably best to just fix them - best not to merge PRs which do not pass the tests... |
DimitriPapadopoulos
force-pushed
the
C4
branch
from
f3211c7 to
def772c
Compare
|
Should be fixed by running $ ruff check --preview --select E231 numpy/_core/tests/test_nditer.py --fix
Found 33 errors (33 fixed, 0 remaining).
$ |
mhvk
reviewed
Aug 27, 2024
DimitriPapadopoulos
force-pushed
the
C4
branch
2 times, most recently
from
64a8569 to
a887b51
Compare
charris
reviewed
Aug 29, 2024
charris
reviewed
Aug 29, 2024
charris
requested changes
Aug 29, 2024
C410 Unnecessary `list` literal passed to `list()`
(remove the outer call to `list()`)
C414 Unnecessary `list` call within `sorted()`
C416 Unnecessary `list` comprehension (rewrite using `list()`)
E231 Missing whitespace after ',' Apply to a single file to please the current linter.
C417 Unnecessary `map` usage (rewrite using a generator expression)
C419 Unnecessary list comprehension
DimitriPapadopoulos
force-pushed
the
C4
branch
from
a887b51 to
486ad9b
Compare
charris
approved these changes
Aug 30, 2024
|
Thanks @DimitriPapadopoulos . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #24994.