MAINT: Do not exclude typing/tests/data from ruff
#29479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
ruff-typing-tests-data
branch
from
fa4ef6b to
ec0ba44
Compare
jorenham
reviewed
Jul 30, 2025
| "numpy/_typing/_array_like.py" = ["E501"] | ||
| "numpy/_typing/_dtype_like.py" = ["E501"] | ||
| "numpy*pyi" = ["E501"] | ||
| # "useless assignments" aren't so useless when you're testing that they don't make type checkers scream |
jorenham
approved these changes
Jul 30, 2025
|
I suppose this explains why my mental linter kept reporting unsorted imports in the type-tests |
|
Thanks Marco :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're spending too long manually fixing these up
I just let
spin lint --fixdo its thing, none of the changes (except those toruff.tomlwere manual)