BUG: Fix TypeError when raising TypeError #7609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes "TypeError: pop expected at least 1 arguments, got 0"
| @@ -244,7 +244,7 @@ def broadcast_arrays(*args, **kwargs): | |||
| subok = kwargs.pop('subok', False) | |||
| if kwargs: | |||
| raise TypeError('broadcast_arrays() got an unexpected keyword ' | |||
| 'argument {}'.format(kwargs.pop())) | |||
| 'argument {!r}'.format(kwargs.keys()[0])) | |||
There was a problem hiding this comment.
Any particular reason for !r instead of !s?
There was a problem hiding this comment.
!r (= repr) will put quotes around the key and escape any weird junk that might be in it, both of which seem like good things to me in this context
There was a problem hiding this comment.
!r is what a normal TypeError due to extra kwargs seems to do
|
Should add a test in |
|
Thanks @eric-wieser . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "TypeError: pop expected at least 1 arguments, got 0"