BUG: Check for HAVE_LDOUBLE_DOUBLE_DOUBLE_LE in npy_math_complex. #7931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_real_part_reciprocal` function is coded in two ways, one depending on functions specific to IEEE floating point and the other using generic code that should always work. Because PPC long double is not IEEE the generic version should always be chosen for that architecture, but that is currently only done when the PPC is configured as big endian. This PR makes sure that the generic version is also chosen when the PPC is configured as little endian. Closes numpy#7836.
|
This is "obviously correct" and I think it should fix #7836, but let's wait until that is verified before merging. |
|
@bbelgodere Can you verify that this fixes your problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_real_part_reciprocalfunction is coded in two ways, one dependingon functions specific to IEEE floating point and the other using generic
code that should always work. Because PPC long double is not IEEE the
generic version should always be chosen for that architecture, but that
is currently only done when the PPC is configured as big endian. This
PR makes sure that the generic version is also chosen when the PPC is
configured as little endian.
Closes #7836.