ENH: Improve announce to find github squash-merge commits. #8181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when the squash-merge button is hit on github, the PR title with "(#PR)" appended is used as the commit message summary line when the merge is fast-forwarded. This PR adds the ability to pick out the corresponding PR numbers from the git log output. Note that github may change this in the future and one early squash merge in the 1.12.0 release did not have the PR number appended.
|
Merged, thanks @charris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the squash-merge button is hit on github, the PR title
with "(#PR)" appended is used as the commit message summary line when
the merge is fast-forwarded. This PR adds the ability to pick out the
corresponding PR numbers from the git log output.
Note that github may change this in the future and one early squash
merge in the 1.12.0 release did not have the PR number appended.