Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix ndarray.tofile large file corruption in append mode. #8341

Merged
merged 1 commit into from Dec 5, 2016

Conversation

Projects
None yet
2 participants
@charris
Copy link
Member

commented Dec 5, 2016

Backport of #8335.

Fixes by using the flag FALLOC_FL_KEEP_SIZE (=1) in the fappend call.

Fixes #8329

BUG: numpy.ndarray.tofile creates a corrupt file for large arrays in …
…append file mode

Fixes by using the flag `FALLOC_FL_KEEP_SIZE` (=1) in the `fappend` call.

Fixes #8329

@charris charris merged commit 667dff7 into numpy:maintenance/1.11.x Dec 5, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@charris charris deleted the charris:backport-8335 branch Dec 5, 2016

@charris charris restored the charris:backport-8335 branch Dec 5, 2016

@charris charris deleted the charris:backport-8335 branch Dec 5, 2016

charris added a commit to charris/numpy that referenced this pull request Dec 5, 2016

TST: Fix tests in PR numpy#8341 for NumPy 1.11.x
numpygh-8341 was a backport and the tests were fixed for pypy, but the
corresponding constant PYPY is undefined in 1.11.x.

charris added a commit that referenced this pull request Dec 5, 2016

Merge pull request #8346 from charris/fix-backport-8335
TST: Fix tests in PR #8341 for NumPy 1.11.x

jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Jan 1, 2017

wiz
Updated py-numpy to 1.11.3.
==========================
NumPy 1.11.3 Release Notes
==========================

Numpy 1.11.3 fixes a bug that leads to file corruption when very large files
opened in append mode are used in ``ndarray.tofile``. It supports Python
versions 2.6 - 2.7 and 3.2 - 3.5. Wheels for Linux, Windows, and OS X can be
found on PyPI.


Contributors to maintenance/1.11.3
==================================

A total of 2 people contributed to this release.  People with a "+" by their
names contributed a patch for the first time.

- Charles Harris
- Pavel Potocek +

Pull Requests Merged
====================

- `#8341 <https://github.com/numpy/numpy/pull/8341>`__: BUG: Fix ndarray.tofile large file corruption in append mode.
- `#8346 <https://github.com/numpy/numpy/pull/8346>`__: TST: Fix tests in PR #8341 for NumPy 1.11.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.