ENH: Better warning for sections. #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) if the number of -/= is too short/ too long warn, Especially too short it won't be detected as a section. 2) for duplicate section print the docstring to figure out where the problem is.
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 92.82% 93.09% +0.26%
==========================================
Files 7 7
Lines 1255 1260 +5
==========================================
+ Hits 1165 1173 +8
+ Misses 90 87 -3 |
|
Can you update some tests? |
|
Done. |
|
Thanks @Carreau |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the number of -/= is too short/ too long warn, Especially too
short it won't be detected as a section.
for duplicate section print the docstring to figure out where the
problem is.