Skip to content

Upper bound jinja #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2022
Merged

Upper bound jinja #369

merged 2 commits into from
Mar 29, 2022

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman commented Mar 29, 2022 •
edited
Loading

@jarrodmillman jarrodmillman added this to the 1.2.1 milestone Mar 29, 2022
@rossbar rossbar mentioned this pull request Mar 29, 2022
Merged
@jarrodmillman jarrodmillman requested a review from rossbar March 29, 2022 21:24
rossbar
rossbar approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See sphinx-doc/sphinx#10291

AIUI this pin will be necessary in order to continue supporting sphinx versions prior to 4.X.

@jarrodmillman
Copy link
Member Author

I think it would make sense to drop some of the older sphinx versions for the 1.3 release.

  • Sphinx 1.8 was only tested on Python <=3.6 and 3.6 was EOL last year
  • Sphinx 2.0 added support for python 3.7.
  • Sphinx 3.1 added support for python 3.8, which most of us have as a minimum supported python version per NEP 29.

@jarrodmillman jarrodmillman merged commit 96a1c0b into numpy:main Mar 29, 2022
@jarrodmillman jarrodmillman deleted the jinja3.1 branch March 30, 2022 15:02
@jarrodmillman jarrodmillman mentioned this pull request Apr 5, 2022
Closed
@rossbar rossbar mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossbar rossbar rossbar approved these changes

Assignees
No one assigned
Labels
type: Bug fix type: Maintenance
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jarrodmillman @rossbar