Skip to content

fix(components): add missing ui prop in prose proxy components #5205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 11, 2025
Merged

fix(components): add missing ui prop in prose proxy components #5205

merged 7 commits into from
Oct 11, 2025

Conversation

@HugoRCD
Copy link
Member

@HugoRCD HugoRCD commented Oct 10, 2025 •
edited by benjamincanac
Loading

🔗 Linked issue

Resolves #5190

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@HugoRCD HugoRCD self-assigned this Oct 10, 2025
@github-actions github-actions bot added the v4 #4488 label Oct 10, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 10, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@5205

commit: 2241a47

benjamincanac
benjamincanac requested changes Oct 10, 2025
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be done in ProseCollapsible and ProseTabs as well!

benjamincanac
benjamincanac reviewed Oct 10, 2025
View reviewed changes
@HugoRCD @benjamincanac
Update src/runtime/components/prose/Accordion.vue
72c935f 
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
@benjamincanac benjamincanac changed the title feat(ProseAccordion): add :ui prop feat(ProseAccordion): add ui prop Oct 10, 2025
@HugoRCD HugoRCD changed the title feat(ProseAccordion): add ui prop feat(prose-components): add missing ui props Oct 10, 2025
benjamincanac
benjamincanac requested changes Oct 10, 2025
View reviewed changes
benjamincanac
benjamincanac requested changes Oct 11, 2025
View reviewed changes
@benjamincanac benjamincanac changed the title feat(prose-components): add missing ui props fix(components): add missing ui prop in prose proxy components Oct 11, 2025
@benjamincanac benjamincanac merged commit d1afe90 into v4 Oct 11, 2025
15 checks passed
@benjamincanac benjamincanac deleted the feat/5190 branch October 11, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

@HugoRCD HugoRCD

Labels

v4 #4488

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can not set ui some Prose Components

2 participants

@HugoRCD @benjamincanac