Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing description of options in user guide #14240

Closed
CyrilleB79 opened this issue Oct 12, 2022 · 3 comments · Fixed by #15950
Closed

Confusing description of options in user guide #14240

CyrilleB79 opened this issue Oct 12, 2022 · 3 comments · Fixed by #15950
Labels
component/documentation p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@CyrilleB79
Copy link
Collaborator

CyrilleB79 commented Oct 12, 2022

Since recently, the user guide uses definition lists to describe new options, more specifically their default and possible values. I feel it confusing.

Steps to reproduce:

Actual behavior:

  • List is reported with 4 item but navigating with I allows to get only two items
  • On the contrary to standard lists (<ul>), definition list do not present bullets for each item (<dt> or maybe <dl>); thus it's not easy to understand where the term is and where the description is.
  • More generally, the semantic between terms and their definition / description is not present.

Expected behavior:

The issue with definition list is discussed in #3858. It does not seem that its resolution is a priority and even if it was, the solution proposed in #3858 would not lead to a satisfactory UX when reading the User Guide. Indeed, it is written:

NVDA should announce "Term" for each dt element.

This would lead to hearing "term option" and "term default" which seems strange. "term" for definition lists, but not for description list.

Since I do not expect #3858 to be resolved soon, I suggest to avoid using definition list in the User Guide. Instead, we may use tables or normal lists.

NVDA logs, crash dumps and other attachments:

N/A

System configuration

NVDA installed/portable/running from source:

N/A

NVDA version:

2022.3

Windows version:

N/A

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

N/A

Other questions

Does the issue still occur after restarting your computer?

N/A

Have you tried any other versions of NVDA? If so, please report their behaviors.

Not looked at.

If NVDA add-ons are disabled, is your problem still occurring?

N/A

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

N/A

@CyrilleB79
Copy link
Collaborator Author

Cc @Qchristensen

@Brian1Gaff
Copy link

Brian1Gaff commented Oct 12, 2022 via email

@seanbudd seanbudd added component/documentation p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority and removed p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority labels Oct 18, 2022
@seanbudd
Copy link
Member

We are going to prioritise #3858, however in the meantime we welcome adjusting the user guide to use tables instead of definition lists.

@seanbudd seanbudd added the triaged Has been triaged, issue is waiting for implementation. label Oct 18, 2022
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Dec 22, 2023
@seanbudd seanbudd modified the milestones: 2024.2, 2024.1 Dec 22, 2023
Adriani90 pushed a commit to Adriani90/nvda that referenced this issue Mar 13, 2024
Fixes nvaccess#14240

Summary of the issue:
Definition lists are not exposed correctly in NVDA.
They are also not supported in markdown natively.
In order to convert text2tags to markdown, these must be converted to tables

Description of user facing changes
Definition lists are now tables in the user guide, which are exposed better by NVDA.

The user guide standards have been updated to encourage the following format for documenting settings.
The standards have been expanded to further document settings in a well structured manner.
This is to improve readability, creating a simple standard to learn more about a settings documentation.
This also allows for the future of automatically collating tables into a settings reference similar to key commands.

Options	Default (Enabled), Enabled, Disabled
Default	Enabled
Toggle command	nvda+shift+e
Option	Behaviour
Enabled	behaviour of enabled
Disabled	behaviour of enabled
Description of development approach
All t2t files had definition lists converted to markdown.
The following regex was used to perform the conversion.

To remove the definition list terminator :

Find: ((^:.+\n  .*\n)+):
replace: $1
To replace rows:

Find: ^: (.*)\n  (.*)\n
Replace: || $1 | $2 |\n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/documentation p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
4 participants