Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA UI pop-up dialog focus issues #28

Closed
nvaccessAuto opened this issue Jan 1, 2010 · 3 comments
Closed

NVDA UI pop-up dialog focus issues #28

nvaccessAuto opened this issue Jan 1, 2010 · 3 comments
Assignees
Milestone

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2008-02-12 08:55
There are several issues with regard to foreground focus and NVDA UI pop-up dialogs:

  • While the NVDA UI window is open, pop-up dialogs such as the Exit NVDA dialog intermittently do not come to the foreground so that it is necessary to press alt+tab to access them, as reported in Interface window doesn't come to foreground on Insert+Q #7.
  • If the NVDA UI window is open, after an NVDA pop-up dialog is dismissed, the focus returns to the NVDA UI window instead of to the window which had the focus before the dialog was popped up.

These are proving to be a little difficult to solve. Some thoughts:

  • All dialogs, including those generated by scriptUI, should have a parent of the NVDA UI window instead of None.
  • When bringing up a scriptUI dialog, if the main UI window is not currently shown, perhaps Show() should be called which should bring it into focus, similar to the code for the Exit NVDA dialog.
  • It seems that winUser.setForegroundWindow() does work quite nicely, despite my earlier findings. This may solve many problems, particularly the second issue described above.
  • All of this fiddly code should be abstracted in some way; i.e. the code to prepare for showing a dialog and the code to restore focus after displaying the dialog.
    Blocking Interface window doesn't come to foreground on Insert+Q #7
@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2008-02-29 05:45
More investigation revealed that !SetForegroundWindow() may not work if another process is in the foreground. This is by design, but it means that we can't use this to reliably bring the NVDA window into focus.

The GUI has needed a complete makeover for a while now, so rather than try to fix this issue, I decided to completely rework the GUI. This was committed in r1745. There is now no NVDA main window (everything is done from the system tray), which means that this problem should not occur.

Closing as fixed. If there are further problems, reopen this ticket.
Changes:
State: closed

@nvaccessAuto
Copy link
Author

Comment 3 by cmssystem on 2013-07-22 20:45
I'm having issues with pop up dialog for a crm system and wonder if it is related to this fix. I can't find the changeset r1745 anymore, does anyone know if there is a way i can look at the changeset ?

Best regards
crm system

@nvaccessAuto
Copy link
Author

Comment 4 by cmssystem (in reply to comment 3) on 2013-07-22 20:47
Replying to crm system:

Never mind. Found the issue.

I'm having issues with pop up dialog for a crm system and wonder if it is related to this fix. I can't find the changeset r1745 anymore, does anyone know if there is a way i can look at the changeset ?

Best regards

crm system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants