New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSHTML virtual buffer: aria-labelledby handling broken #4575

Closed
nvaccessAuto opened this Issue Oct 26, 2014 · 4 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto

nvaccessAuto commented Oct 26, 2014

Reported by jteh on 2014-10-26 02:07
aria-labelledby isn't handle as expected in the MSHTML vbuf backend. I suspect this is due to the fact that we're retrieving the attribute using aria-labelledBy (note the capital b) but testing for aria-labelledby (no capital).

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Nov 20, 2014

Comment 1 by jteh on 2014-11-20 08:05
These really should have been done for 2014.4, but we're out of time and they aren't absolutely critical. Still, we need to manage this better in future.
Changes:
Milestone changed from 2014.4 to 2015.1

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 16, 2015

Comment 2 by Michael Curran <mick@... on 2015-01-16 03:11
In [59e83ab]:

MSHTML virtualBuffer: fix up spelling of aria-labelledby and aria-describedby (the b should not be uppercase). Also remove specific fetching of aria-labelledby from NVDA as the virtualBuffer backend already handles this.

Fixing the spelling more importantly makes NVDA actually render the correct label for aria-labelledby, overriding the existing content. Re #4575

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 16, 2015

Comment 3 by Michael Curran <mick@... on 2015-01-16 03:11
In [8d63cbb]:

Merge branch 't4575' into next. Incubates #4575

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 30, 2015

Comment 4 by Michael Curran <mick@... on 2015-01-30 02:06
In [30fc6bd]:

Merge branch 't4575'. Fixes #4575

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto nvaccessAuto added this to the 2015.1 milestone Nov 10, 2015

michaelDCurran added a commit that referenced this issue Nov 23, 2015

MSHTML virtualBuffer: fix up spelling of aria-labelledby and aria-des…
…cribedby (the b should not be uppercase). Also remove specific fetching of aria-labelledby from NVDA as the virtualBuffer backend already handles this.

Fixing the spelling more importantly makes NVDA actually render the correct label for aria-labelledby, overriding the existing content. Re #4575

michaelDCurran added a commit that referenced this issue Nov 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment