New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to show Speech Viewer by default (and save dimensions and position of the window) #5050

Closed
nvaccessAuto opened this Issue Apr 23, 2015 · 15 comments

Comments

Projects
None yet
7 participants
@nvaccessAuto

nvaccessAuto commented Apr 23, 2015

Reported by jmuheim on 2015-04-23 06:41
I'm a sighted user and I'm using NVDA only with "no speech" option and with the speech viewer open. This makes it much faster for me to use, as I can jump to the relevant parts of the output directly by scanning through the speech viewer visually.

I know that I can open the speech viewer using NVDA+N, then T, then S, but this is cumbersome. I'd like to have an option "Display speech viewer when starting NVDA", as I normally start NVDA only for a few seconds, and then I quit it again so it doesn't interfere my keyboard (and slow down my computer, which is a Windows 7 virtual machine on Mac OS X).

In addition, it would be very nice if the window's last dimensions (width/height) and position (x/y) were remembered, as I usually want it side by side with my browser so they don't overlap each other.

I really hope this will be implemented. I'm working for the best known accessibility consultancy in Switzerland, and we are trying to get our clients to use NVDA themselves to produce highly accessible websites themselves without our help. So it would really make sense to make NVDA appeal a little bit more to sighted users, as typically it's them who create the websites that blind people use.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Apr 23, 2015

Comment 1 by jmuheim on 2015-04-23 06:41
This would maybe also help people asking for a shorter keyboard shortcut for the speech viewer:

http://community.nvda-project.org/ticket/1507

nvaccessAuto commented Apr 23, 2015

Comment 1 by jmuheim on 2015-04-23 06:41
This would maybe also help people asking for a shorter keyboard shortcut for the speech viewer:

http://community.nvda-project.org/ticket/1507

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Apr 23, 2015

Comment 2 by leonarddr on 2015-04-23 06:47
it is intended to include #4898 in 2015.2, which add the possibility to set a toggle hotkey for speech viewer. In that case, you will only have to start nvda and press a second hotkey to start speech viewer. Would that be enough for you?

nvaccessAuto commented Apr 23, 2015

Comment 2 by leonarddr on 2015-04-23 06:47
it is intended to include #4898 in 2015.2, which add the possibility to set a toggle hotkey for speech viewer. In that case, you will only have to start nvda and press a second hotkey to start speech viewer. Would that be enough for you?

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Apr 23, 2015

Comment 3 by jmuheim on 2015-04-23 06:49
If you add the remember dimension and position feature, I will be more than happy!

nvaccessAuto commented Apr 23, 2015

Comment 3 by jmuheim on 2015-04-23 06:49
If you add the remember dimension and position feature, I will be more than happy!

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto May 13, 2015

Attachment t5050-1.patch added by cannona on 2015-05-13 20:18
Description:
WIP: everything except remembering size and position.

nvaccessAuto commented May 13, 2015

Attachment t5050-1.patch added by cannona on 2015-05-13 20:18
Description:
WIP: everything except remembering size and position.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto May 13, 2015

Comment 4 by cannona on 2015-05-13 20:27
This patch adds an option to general preferences and when set, auto-starts the speech viewer.

Questions for the devs:

  1. Should this option be in General, or some other screen?
  2. I'm uncertain as to how best to get/set the size and position. Initial thoughts are to add some code in the deactivate method of the SpeechViewer class which records the current window size and position, and some coorisponding code which restores it in __init. I think I can get this information from self.getPosition() and self.getSize(), but not entirely sure. Any ideas on this? Sound like the right track?
  3. Once I have the position data, where should I store it? In config?

Thanks for any feedback.

nvaccessAuto commented May 13, 2015

Comment 4 by cannona on 2015-05-13 20:27
This patch adds an option to general preferences and when set, auto-starts the speech viewer.

Questions for the devs:

  1. Should this option be in General, or some other screen?
  2. I'm uncertain as to how best to get/set the size and position. Initial thoughts are to add some code in the deactivate method of the SpeechViewer class which records the current window size and position, and some coorisponding code which restores it in __init. I think I can get this information from self.getPosition() and self.getSize(), but not entirely sure. Any ideas on this? Sound like the right track?
  3. Once I have the position data, where should I store it? In config?

Thanks for any feedback.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto May 13, 2015

Comment 5 by nvdakor (in reply to comment 4) on 2015-05-13 20:44
Replying to cannona:

  1. Should this option be in General, or some other screen?

I'd say general settings would be fine, but I'd say it should not be available in secure screens.

  1. I'm uncertain as to how best to get/set the size and position. Initial thoughts are to add some code in the deactivate method of the SpeechViewer class which records the current window size and position, and some coorisponding code which restores it in __init. I think I can get this information from self.getPosition() and self.getSize(), but not entirely sure. Any ideas on this? Sound like the right track?

Few concerns:

  1. What if someone attempts to launch NVDA on a computer with a different screen resolution? In my case, my desktop has a 720P screen, while my laptop uses 1080P resolution.
  2. One needs to be careful about screen sizes, otherwise some parts of the viewer window might be cut off or may appear blurred.
    I think storing percentages would be better (say, if I'm to look at this, it should be on the bottom right, say 10 percent from the right edge, 10 percent from the bottom edge). Then someone will come in and ask that foreground and background color be configurable, which is way off the scope of this ticket and cannot be implemented easily by a group of people who cannot see colors (well, they can get some sense of which color combinations will work best).
  1. Once I have the position data, where should I store it? In config?

I agree - what we have in config dictionary are keys that control things such as progress bar output interval, voice settings that'll apply on all synthesizers and so on. I think, for sake of clarity and to allow add-ons to work with speech viewer location, I'd say a separate section for storing speech viewer real estate percentages should be used unless if it can be incorporated into the main config sections.
More code reviews from others are welcome. Thanks.

nvaccessAuto commented May 13, 2015

Comment 5 by nvdakor (in reply to comment 4) on 2015-05-13 20:44
Replying to cannona:

  1. Should this option be in General, or some other screen?

I'd say general settings would be fine, but I'd say it should not be available in secure screens.

  1. I'm uncertain as to how best to get/set the size and position. Initial thoughts are to add some code in the deactivate method of the SpeechViewer class which records the current window size and position, and some coorisponding code which restores it in __init. I think I can get this information from self.getPosition() and self.getSize(), but not entirely sure. Any ideas on this? Sound like the right track?

Few concerns:

  1. What if someone attempts to launch NVDA on a computer with a different screen resolution? In my case, my desktop has a 720P screen, while my laptop uses 1080P resolution.
  2. One needs to be careful about screen sizes, otherwise some parts of the viewer window might be cut off or may appear blurred.
    I think storing percentages would be better (say, if I'm to look at this, it should be on the bottom right, say 10 percent from the right edge, 10 percent from the bottom edge). Then someone will come in and ask that foreground and background color be configurable, which is way off the scope of this ticket and cannot be implemented easily by a group of people who cannot see colors (well, they can get some sense of which color combinations will work best).
  1. Once I have the position data, where should I store it? In config?

I agree - what we have in config dictionary are keys that control things such as progress bar output interval, voice settings that'll apply on all synthesizers and so on. I think, for sake of clarity and to allow add-ons to work with speech viewer location, I'd say a separate section for storing speech viewer real estate percentages should be used unless if it can be incorporated into the main config sections.
More code reviews from others are welcome. Thanks.

@jmuheim

This comment has been minimized.

Show comment
Hide comment
@jmuheim

jmuheim Nov 11, 2015

Is there any progress on this? And is the shortcut for toggling the speech viewer already available?

PS: woohooo, github issues! Bye bye, Trac! 👍

jmuheim commented Nov 11, 2015

Is there any progress on this? And is the shortcut for toggling the speech viewer already available?

PS: woohooo, github issues! Bye bye, Trac! 👍

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Nov 11, 2015

Contributor

I haven't reviewed this yet myself, but there was some code review above from nvdakor that hasn't been addressed yet.

#4898 was implemented, which means you can now bind your own shortcut in NVDA menu -> Preferences -> Input gestures. It is unbound by default.

Contributor

jcsteh commented Nov 11, 2015

I haven't reviewed this yet myself, but there was some code review above from nvdakor that hasn't been addressed yet.

#4898 was implemented, which means you can now bind your own shortcut in NVDA menu -> Preferences -> Input gestures. It is unbound by default.

@jmuheim

This comment has been minimized.

Show comment
Hide comment
@jmuheim

jmuheim Nov 11, 2015

#4898 was implemented, which means you can now bind your own shortcut in NVDA menu -> Preferences -> Input gestures. It is unbound by default.

That's nice. Thank you! Still, remembering its position would be really useful (also between restarts), as the window doesn't react on standard Windows positioning possibilities, e.g. dragging it to the corner of the screen, etc.

jmuheim commented Nov 11, 2015

#4898 was implemented, which means you can now bind your own shortcut in NVDA menu -> Preferences -> Input gestures. It is unbound by default.

That's nice. Thank you! Still, remembering its position would be really useful (also between restarts), as the window doesn't react on standard Windows positioning possibilities, e.g. dragging it to the corner of the screen, etc.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Nov 11, 2015

Collaborator

Hi,

This is nvdakor…

I’m not sure if Aaron is part of committers list…

As Jamie mentioned, the points I raised in the code review (using percentages and config storage) were not acted upon yet.

Thanks.

From: James Teh [mailto:notifications@github.com]
Sent: Wednesday, November 11, 2015 3:54 AM
To: nvaccess/nvda nvda@noreply.github.com
Subject: Re: [nvda] Option to show Speech Viewer by default (and save dimensions and position of the window) (#5050)

I haven't reviewed this yet myself, but there was some code review above from nvdakor that hasn't been addressed yet.

#4898 #4898 was implemented, which means you can now bind your own shortcut in NVDA menu -> Preferences -> Input gestures. It is unbound by default.


Reply to this email directly or view it on GitHub #5050 (comment) .

Collaborator

josephsl commented Nov 11, 2015

Hi,

This is nvdakor…

I’m not sure if Aaron is part of committers list…

As Jamie mentioned, the points I raised in the code review (using percentages and config storage) were not acted upon yet.

Thanks.

From: James Teh [mailto:notifications@github.com]
Sent: Wednesday, November 11, 2015 3:54 AM
To: nvaccess/nvda nvda@noreply.github.com
Subject: Re: [nvda] Option to show Speech Viewer by default (and save dimensions and position of the window) (#5050)

I haven't reviewed this yet myself, but there was some code review above from nvdakor that hasn't been addressed yet.

#4898 #4898 was implemented, which means you can now bind your own shortcut in NVDA menu -> Preferences -> Input gestures. It is unbound by default.


Reply to this email directly or view it on GitHub #5050 (comment) .

@jmuheim

This comment has been minimized.

Show comment
Hide comment
@jmuheim

jmuheim Jun 24, 2016

Is there any news on this? It would be really useful if the speech viewer remembered its position when closing and reopening it (also between restarts of NVDA).

jmuheim commented Jun 24, 2016

Is there any news on this? It would be really useful if the speech viewer remembered its position when closing and reopening it (also between restarts of NVDA).

@jmuheim

This comment has been minimized.

Show comment
Hide comment
@jmuheim

jmuheim Jun 24, 2016

Or at least make it possible to snap it to a corner of the screen by Windows' window snapping mechanism

jmuheim commented Jun 24, 2016

Or at least make it possible to snap it to a corner of the screen by Windows' window snapping mechanism

@nvaccessAuto nvaccessAuto added the p2 label Jul 5, 2016

@feerrenrut feerrenrut self-assigned this Jul 20, 2016

@dougbacelar

This comment has been minimized.

Show comment
Hide comment
@dougbacelar

dougbacelar Jul 20, 2016

So, was the shortcut for the speech viewer implemented or what? can't get it to work.

dougbacelar commented Jul 20, 2016

So, was the shortcut for the speech viewer implemented or what? can't get it to work.

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Jul 20, 2016

Collaborator

You will have to add one manually as @jcsteh noted above. It is in nvda menu>prefferences>input gestures>tools>Toggles the NVDA Speech viewer, a floating window that allows you to view all the text that NVDA is currently speaking

Collaborator

leonardder commented Jul 20, 2016

You will have to add one manually as @jcsteh noted above. It is in nvda menu>prefferences>input gestures>tools>Toggles the NVDA Speech viewer, a floating window that allows you to view all the text that NVDA is currently speaking

@dougbacelar

This comment has been minimized.

Show comment
Hide comment
@dougbacelar

dougbacelar Jul 22, 2016

Thanks, it worked :)

dougbacelar commented Jul 22, 2016

Thanks, it worked :)

feerrenrut added a commit that referenced this issue Jul 29, 2016

incubates #6197
Adds option to open speech viewer on startup. Re #5050

Merge branch 'i5050-AddOptionForSpeechViewerOnStartup' into next

feerrenrut added a commit that referenced this issue Jul 29, 2016

incubates #6202
Speech viewer attempts to re-open with the same size at last location.
Re #5050

Merge branch 'i5050-RememberPositionOfSpeechViewer' into next

feerrenrut added a commit that referenced this issue Aug 31, 2016

Update changes file for PR #6201
Fixed a rare issue when exiting NVDA while the speech viewer is open causing an error. (#5050)

@feerrenrut feerrenrut closed this in #6197 Aug 31, 2016

feerrenrut added a commit that referenced this issue Aug 31, 2016

Update changes file for PR #6197
An option to open the speech viewer window on startup has been added. (#5050)

feerrenrut added a commit that referenced this issue Aug 31, 2016

#5050 Remember the position and size of the speechViewer (#6202)
The speechViewer window will open in the same location at the same size
as it was when previously closed. If the monitor setup has changed
(resolution, or number of monitors) the window is auto positioned/sized.

feerrenrut added a commit that referenced this issue Aug 31, 2016

Update changes file for PR #6202
When re-opening the speech viewer window, the location and dimensions will now be restored. (#5050)

@jcsteh jcsteh added this to the 2016.4 milestone Aug 31, 2016

josephsl added a commit to josephsl/nvda that referenced this issue Oct 28, 2016

What's new: linguistic fixes and clarifications. re #6517, #6520
Specifically:
* #5906: Now labeled as 'line indentation reporting'.
* #6099: clarify how to change values in spin controls.
* #5886: elements list is available in browse mode.
* #6206: changed bits such as 'adding new entries'.
* #6127: no more hyphen (dash).
* #5050: 'causes' -> 'which caused'.
* #4164: changed wording to reflect that read-only edit fields are now included.

josephsl added a commit to josephsl/nvda that referenced this issue Oct 31, 2016

What's new, cosmetic fixes.
Reviewed by Reef Turner (NV Access):
* #6127: no user visible change, so removed.
* #5050: Make it simpler as suggested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment