GUI: use spin boxes for number entry fields such as message timeout in braille dialog and others #6099

Closed
josephsl opened this Issue Jun 21, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@josephsl
Collaborator

josephsl commented Jun 21, 2016

Hi,

For controls that accept numbers as input, there are several methods to manipulate values:

  • Strict text entry (currnet implementation)
  • List (limited to a set of choices)
  • Spin box: An edit field that allows users to use up and down arrows to change values.

I'd like to propose that we use the third method. Benefits include users not having to worry about entering wrong values as the control itself knows min and max, just using arrow keys to change values, allow touch users to change values by tapping the spin button control and others. The only possible disadvantage I see here is denoting min and max for certain options - for this, a reasonable range should be provided.

The following options could be enhanced via spin boxes:

  • Braille settings: message timeout, cursor blinking rate.
  • Browse mode: max characters per line and lines per page.
  • Others when it is safe to convert them to spin boxes.

Thanks.

@dkager

This comment has been minimized.

Show comment
Hide comment
@dkager

dkager Jun 22, 2016

Collaborator

Sounds good. For braille settings I've wondered why they weren't spinners before. But the min/max should be obtained from the config structure if at all possible. By the way, the braille cursor blink rate currently doesn't have a sane minimum (100 or even 200ms should work).

Collaborator

dkager commented Jun 22, 2016

Sounds good. For braille settings I've wondered why they weren't spinners before. But the min/max should be obtained from the config structure if at all possible. By the way, the braille cursor blink rate currently doesn't have a sane minimum (100 or even 200ms should work).

@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Sep 7, 2016

Contributor

We should give the wx.SpinCtrl a go, this would be a quick fix if wx.SpinCtrl is acceptable from an accessibility standpoint.

Contributor

feerrenrut commented Sep 7, 2016

We should give the wx.SpinCtrl a go, this would be a quick fix if wx.SpinCtrl is acceptable from an accessibility standpoint.

feerrenrut added a commit that referenced this issue Sep 30, 2016

fix for #6099 use spin controls
For numerical input fields a wx SpinCtrl is now used. The min/max values
come from the nvda config schema validation (if available).

@feerrenrut feerrenrut self-assigned this Sep 30, 2016

feerrenrut added a commit that referenced this issue Oct 12, 2016

incubates #6417
Fixes issue #6099
Merge branch 'i6099-useWxSpinCtrl' into next

Conflicts:
	source/gui/nvdaControls.py
	source/gui/settingsDialogs.py

@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Oct 27, 2016

feerrenrut added a commit that referenced this issue Oct 27, 2016

Update changes file for PR #6417
Spin Controls are now used for numerical input fields. (#6099)

josephsl added a commit to josephsl/nvda that referenced this issue Oct 28, 2016

What's new: linguistic fixes and clarifications. re #6517, #6520
Specifically:
* #5906: Now labeled as 'line indentation reporting'.
* #6099: clarify how to change values in spin controls.
* #5886: elements list is available in browse mode.
* #6206: changed bits such as 'adding new entries'.
* #6127: no more hyphen (dash).
* #5050: 'causes' -> 'which caused'.
* #4164: changed wording to reflect that read-only edit fields are now included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment