Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating menu items on webpages is needlessly complicated #6735

Closed
Simon818 opened this issue Jan 16, 2017 · 12 comments
Closed

Activating menu items on webpages is needlessly complicated #6735

Simon818 opened this issue Jan 16, 2017 · 12 comments
Assignees
Milestone

Comments

@Simon818
Copy link

@Simon818 Simon818 commented Jan 16, 2017

One of my favourite websites recently switched from a link-based sidebar to a bunch of submenus with menu items. The layout makes a lot of sense visually, and it's pretty fancy. One of the things I noticed when trying to browse it is the fact that I have to turn on focus mode to activate a menu item... for some reason. When I press enter on one, focus mode turns on, and I have to press enter again. It's almost easier to just tab through the site at this point. There may be reasoning for this, and it seems like something that would have been changed before now had it been a serious issue, but right now I'm finding it to be a major annoyance and am not sure why I can't just click on them like anything else.
There also doesn't seem to be a keyboard command to move to the next menu, or menu item. They seem to be more and more common on webpages, and right now I'm not finding a way to deal with them very well in NVDA. I'm just a user, so suggestions are of course, welcome.

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Jan 16, 2017

@jcsteh jcsteh added the ARIA label Jan 16, 2017
@Simon818
Copy link
Author

@Simon818 Simon818 commented Jan 16, 2017

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Jan 16, 2017

@jcsteh jcsteh added the p2 label Jan 16, 2017
@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Jan 16, 2017

Implementation note: I think we could do the same thing we do for radio buttons here; i.e. switch to focus mode if they get focus, but just activate them if you press enter from browse mode. That should allow us to keep a decent native keyboard navigation experience while improving things in browse mode.

P2 because we're focusing on ARIA fixes soonish.

@derekriemer
Copy link
Collaborator

@derekriemer derekriemer commented Jan 16, 2017

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Jan 16, 2017

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Jan 16, 2017

@feerrenrut
Copy link
Member

@feerrenrut feerrenrut commented Jan 17, 2017

I think the following example demonstrates the described issue: http://oaa-accessibility.org/example/25/

@feerrenrut feerrenrut self-assigned this Jan 18, 2017
@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Jan 18, 2017

This following (not at all realistic) example can be used for testing:

<button>Before</button>
<div tabindex="0" role="menuitem" onClick="alert('Gotcha');">Cheese</div>
<button>After</button>
  1. Switching to browse mode then tabbing to the menu item should switch to focus mode. Currently works.
  2. Switching to browse mode, cursoring to the menu item, then pressing enter should bring up the dialog. Currently doesn't work.
@leonardder
Copy link
Collaborator

@leonardder leonardder commented Jan 18, 2017

@derekriemer
Copy link
Collaborator

@derekriemer derekriemer commented Jan 18, 2017

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Jan 18, 2017

This is assigned to @feerrenrut and he's already working on it. Thanks.

feerrenrut added a commit that referenced this issue Jan 19, 2017
Fix for #6735
Menu items (as well as menu item checkbox and menu item radio) can be
now be activated while in browse mode.
feerrenrut added a commit that referenced this issue Feb 1, 2017
For issue #6735
Merge remote-tracking branch 'origin/i6735-ActivateMenuItemsInBrowseMode' into next
@nvaccessAuto nvaccessAuto added this to the 2017.2 milestone Mar 14, 2017
feerrenrut added a commit that referenced this issue Mar 14, 2017
For PR #6761 - Web page menu items (menu item checkbox's and radio buttons) can now be activated while in browse mode.  Issue #6735
For PR #6866 - Excel sheet name reporting is now translated. Issue #6848
For PR #6884 - Pressing ESC while the configuration profile "Confirm Deletion" prompt is active now dismisses the dialog. Issue #6851
For PR #6895 - Cell border information can now be reported in Microsoft Excel by using `NVDA+f`. Issue #3044
For PR #6860 - Added support for aria-current attributes. Issue #6358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants