I6889 fix excel merged cell regression #6895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6889 The `DisplayFormat` property does not exist on ranges for excel 2007. Instead (if the call to DisplayFormat fails) the borders property is accessed directly on the range object rather than through the `DisplayFormat`
feerrenrut
force-pushed
the
i6889-fixExcelMergedCellRegression
branch
from
5a3439d
to
46a5676
Compare
|
Actually looking at this more closely, there are 2 commits added to the original PR #6492 that were never reviewed. |
|
@nishimotz FYI |
michaelDCurran
approved these changes
Feb 20, 2017
feerrenrut
added a commit
that referenced
this pull request
Feb 20, 2017
feerrenrut
added a commit
that referenced
this pull request
Mar 14, 2017
For PR #6761 - Web page menu items (menu item checkbox's and radio buttons) can now be activated while in browse mode. Issue #6735 For PR #6866 - Excel sheet name reporting is now translated. Issue #6848 For PR #6884 - Pressing ESC while the configuration profile "Confirm Deletion" prompt is active now dismisses the dialog. Issue #6851 For PR #6895 - Cell border information can now be reported in Microsoft Excel by using `NVDA+f`. Issue #3044 For PR #6860 - Added support for aria-current attributes. Issue #6358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #6492. However only one commit is not reviewed (5a3439d)
Fixes #6889 and #3044
This issue seems to effect excel 2007, and not excel 2013.
The relevant difference in the API is the
DisplayFormatproperty that exists in excel 2013 but not in excel 2007. If the call toDisplayFormatfails instead we access the borders via the range.borders property.