New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danish Braille table for entering of Braille is not in NVDA #6773

Closed
andersbp opened this Issue Jan 20, 2017 · 9 comments

Comments

Projects
None yet
6 participants
@andersbp

andersbp commented Jan 20, 2017

The Danish Braille table for entering of Braille is missing in NVDA 2016.04. I fine can select Danish Braille table for reading Braille.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Jan 20, 2017

Collaborator
Collaborator

josephsl commented Jan 20, 2017

@andersbp

This comment has been minimized.

Show comment
Hide comment
@andersbp

andersbp Jan 20, 2017

andersbp commented Jan 20, 2017

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Jan 20, 2017

Collaborator
Collaborator

josephsl commented Jan 20, 2017

@andersbp

This comment has been minimized.

Show comment
Hide comment
@andersbp

andersbp Jan 20, 2017

andersbp commented Jan 20, 2017

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Jan 20, 2017

Collaborator
Collaborator

josephsl commented Jan 20, 2017

@chojiro

This comment has been minimized.

Show comment
Hide comment
@chojiro

chojiro Mar 3, 2017

Seems as if the braille tables for Danish actually work, including 6 and 8 dot contracted and uncontracted, as well as computer braille, both for input and output, though the computer braille table for some reason isn't in braille.py. Also, looks like none of the tables were used to input braille that were already in the file, but only used for output. They're not showing.

It does appear that a few of the table cause issues, like the announcement "st" to be spoken when entering characters using eight dot contracted braille.

Any information on this design implementation would be appreciated. I haven't heard of any issues so far regarding LibLouis and Danish braille.

chojiro commented Mar 3, 2017

Seems as if the braille tables for Danish actually work, including 6 and 8 dot contracted and uncontracted, as well as computer braille, both for input and output, though the computer braille table for some reason isn't in braille.py. Also, looks like none of the tables were used to input braille that were already in the file, but only used for output. They're not showing.

It does appear that a few of the table cause issues, like the announcement "st" to be spoken when entering characters using eight dot contracted braille.

Any information on this design implementation would be appreciated. I haven't heard of any issues so far regarding LibLouis and Danish braille.

@egli

This comment has been minimized.

Show comment
Hide comment
@egli

egli Mar 9, 2017

I'm not quite clear what you're after but as far as Danish computer braille there is da-dk-g08.ctb by Bue Vester-Andersen, which according to the comment is the "Danish table for 8 dots computer Braille".

egli commented Mar 9, 2017

I'm not quite clear what you're after but as far as Danish computer braille there is da-dk-g08.ctb by Bue Vester-Andersen, which according to the comment is the "Danish table for 8 dots computer Braille".

@chojiro

This comment has been minimized.

Show comment
Hide comment
@chojiro

chojiro Mar 9, 2017

Sure. It's the correct table, but as in my previous comment above, I wanted to see why they weren't enabled for input and why computer Braille originally isn't included in the file at all right now. The table seems to work fine, but I have tried reaching out to Bue for a while to find out anything, since he is the maintainer. Barring the slight annoyances with some of the tables, with no forthcoming answer it should be alright for a pull request since it's a very minor change. @andersbp originally seems to want to let people know that input currently does not work for the reason mentioned. So, all there is to say is that it essentially exists, it just isn't enabled for input apparently.

chojiro commented Mar 9, 2017

Sure. It's the correct table, but as in my previous comment above, I wanted to see why they weren't enabled for input and why computer Braille originally isn't included in the file at all right now. The table seems to work fine, but I have tried reaching out to Bue for a while to find out anything, since he is the maintainer. Barring the slight annoyances with some of the tables, with no forthcoming answer it should be alright for a pull request since it's a very minor change. @andersbp originally seems to want to let people know that input currently does not work for the reason mentioned. So, all there is to say is that it essentially exists, it just isn't enabled for input apparently.

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Jul 7, 2017

Contributor

Danish tables can now be selected for input in master thanks to #6449. I'll add the computer braille table in an upcoming pull request. Closing.

Contributor

jcsteh commented Jul 7, 2017

Danish tables can now be selected for input in master thanks to #6449. I'll add the computer braille table in an upcoming pull request. Closing.

@jcsteh jcsteh closed this Jul 7, 2017

@jcsteh jcsteh added this to the 2017.3 milestone Jul 7, 2017

jcsteh added a commit that referenced this issue Jul 7, 2017

New braille translation tables: Danish 8 dot computer braille, Englis…
…h (U.S.) 8 dot extended computer braille, Lithuanian, Slovenian 8 dot computer braille. (issues #6188, #6550, #6773, #6836)

Also, changed the description for "Slovene grade 1" to "Slovenian grade 1" for consistency.

jcsteh added a commit that referenced this issue Jul 10, 2017

New braille translation tables: Danish 8 dot computer braille, Englis…
…h (U.S.) 8 dot extended computer braille, Lithuanian, Persian 8 dot computer braille, Persian grade 1, Slovenian 8 dot computer braille. Incubates #7364 (issues #6188, #6550, #6773, #6836, #7367).

jcsteh added a commit that referenced this issue Aug 1, 2017

New braille translation tables (#7364)
- New braille translation tables: Danish 8 dot computer braille, Lithuanian, Persian 8 dot computer braille, Persian grade 1, Slovenian 8 dot computer braille. (#6188, #6550, #6773, #7367)
- Improved English (U.S.) 8 dot computer braille table, including support for bullets, the euro sign and accented letters. (#6836)
- Changed the description for "Slovene grade 1" to "Slovenian grade 1" for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment