Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When in browse mode in Chrome the label for a div contentEditable is read out as if it is the current value when there is no aria role. #7153

Closed
feerrenrut opened this issue May 8, 2017 · 0 comments · Fixed by #7169
Labels
bug feature/browse-mode p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Milestone

Comments

@feerrenrut
Copy link
Contributor

feerrenrut commented May 8, 2017

When in browse mode in Chrome the label for a div contentEditable is read out as if it is the current value.
When the IA2 role ends up being section or text frame. This can be reproduced by not having an aria role.

Try this URI (with no role):
data:text/html,<div aria-label="foo" aria-placeholder="bar" contentEditable="true"></div>
This reports "foo" after reporting that we are in an editable section.

Versus this URI (with role textBox):
data:text/html,<div aria-label="foo" aria-placeholder="bar" role="textbox" contentEditable="true"></div>
This is the expected behaviour, which does not report "foo" after reporting that we are in an editable section.

Possible fix: Line 807 of nvdaHelper/vbufBackends/gecko_ia2/gecko_ia2.cpp: Need to make sure that the section and text frame roles aren't considered if they are editable (I think !isEditable will do it)

@feerrenrut feerrenrut added feature/browse-mode bug p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority labels May 8, 2017
feerrenrut added a commit that referenced this issue May 9, 2017
This has been split out into another bug, see #7153
feerrenrut added a commit that referenced this issue May 30, 2017
…7169)

Editable div elements in Chrome are no longer have their label reported as their value while in browse mode.

Fixes #7153
@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone May 30, 2017
feerrenrut added a commit that referenced this issue May 30, 2017
- PR #7169 : Editable div elements in Chrome are no longer have their label reported as their value while in browse mode. (Issue #7153)
- PR #6396 : An unbound gesture (script_restart) has been added to allow NVDA to be restarted quickly. (PR #6396)
- PR #6777 : A Braille setting has been added to "show messages indefinitely". (Issue #6669)
- PR #7133 : Pressing end while in browse mode of an empty Microsoft Word document no longer causes a runtime error. (Issue #7009)
- PR #6868 : The keyboard layout can now be set from the NVDA Welcome dialog. (Issue #6863)
- PR #6813 : The names of "landmarks" are abbreviated in Braille (Issue #3975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/browse-mode p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants