Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart NVDA with a single gesture #6396

Merged
merged 1 commit into from May 30, 2017
Merged

Conversation

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Sep 21, 2016

By default, ctrl+nvda+f4 is assigned, but we can consider removing this as well as change it to the current gesture for reloading plugins (ctrl+NVDA+f3).
Even though it is possible to restart NVDA using its desktop shortcut, this way of restarting appears to be much quicker and is a nice alternative for reloading plugins, which would allow for deprecating this as @jcsteh suggested in #6389. Furthermore, it works with portable copies.

The only thing I'm not sure about, do we just want to call core.restart, or use queueHandler.queueFunction(queueHandler.eventQueue,core.restart) as in gui.ExitDialog? I'm sure it's used there for a reason.

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Sep 21, 2016

  1. It's worth noting that despite my original reservations, I managed to
    fixed reload plugins in #6390 (pending review). So, the use case for
    this is somewhat less compelling now. Do you still think this is necessary?
  2. Given that the use case is limited and that there are other ways of
    restarting NVDA relatively quickly (even NVDA+q, r, enter is pretty
    quick), I think this should be unbound by default. We're getting
    somewhat careful about using keystrokes for rarely used commands. :)
@derekriemer
Copy link
Collaborator

@derekriemer derekriemer commented Sep 21, 2016

We could unbind reload plugins, and bind this to that.

On 9/21/2016 4:52 PM, James Teh wrote:

  1. It's worth noting that despite my original reservations, I managed to
    fixed reload plugins in #6390 (pending review). So, the use case for
    this is somewhat less compelling now. Do you still think this is
    necessary?
  2. Given that the use case is limited and that there are other ways of
    restarting NVDA relatively quickly (even NVDA+q, r, enter is pretty
    quick), I think this should be unbound by default. We're getting
    somewhat careful about using keystrokes for rarely used commands. :)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6396 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFGiva_N-tF3FAKYUM59Jj9gbKAcRgjnks5qsbUVgaJpZM4KDMmy.


Derek Riemer
  • Department of computer science, third year undergraduate student.
  • Proud user of the NVDA screen reader.
  • Open source enthusiast.
  • Member of Bridge Cu
  • Avid skiier.

Websites:
Honors portfolio http://derekriemer.com
Awesome little hand built weather app!
http://django.derekriemer.com/weather/

email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu
Phone: (303) 906-2194

@leonardder
Copy link
Collaborator Author

@leonardder leonardder commented Sep 22, 2016

if #6390 gets into master, I think an unbound gesture would be ok.
How about to decide whether to use queueHandler or not?

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Sep 22, 2016

You should be okay to just call core.restart, since this is being done in a script where you're already in the core queue anyway.

@leonardder leonardder force-pushed the BabbageCom:restart_script branch from 9cf7f30 to e1de2fe Sep 22, 2016
@leonardder
Copy link
Collaborator Author

@leonardder leonardder commented Dec 14, 2016

I actually removed the gesture binding to ctrl+nvda+f4, so it is unbound now.

Copy link
Member

@feerrenrut feerrenrut left a comment

Thanks, looks good. Are you able to comment on the testing that has been done on this? Has this been tested with dialogs open, or with addons installed? I think that the about dialog causes problems when trying to exit nvda, that might be to do with wx. It would be nice to know if this also had that behaviour.

@leonardder
Copy link
Collaborator Author

@leonardder leonardder commented Apr 26, 2017

I tested this both with the general settings and about dialogs open and I do not observe strange behavior.

feerrenrut added a commit that referenced this pull request Apr 27, 2017
Merge branch 'BabbageCom-restart_script' into next
@feerrenrut feerrenrut merged commit 9403ff1 into nvaccess:master May 30, 2017
@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone May 30, 2017
feerrenrut added a commit that referenced this pull request May 30, 2017
- PR #7169 : Editable div elements in Chrome are no longer have their label reported as their value while in browse mode. (Issue #7153)
- PR #6396 : An unbound gesture (script_restart) has been added to allow NVDA to be restarted quickly. (PR #6396)
- PR #6777 : A Braille setting has been added to "show messages indefinitely". (Issue #6669)
- PR #7133 : Pressing end while in browse mode of an empty Microsoft Word document no longer causes a runtime error. (Issue #7009)
- PR #6868 : The keyboard layout can now be set from the NVDA Welcome dialog. (Issue #6863)
- PR #6813 : The names of "landmarks" are abbreviated in Braille (Issue #3975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants