-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart NVDA with a single gesture #6396
Conversation
|
We could unbind reload plugins, and bind this to that. On 9/21/2016 4:52 PM, James Teh wrote:
Websites: email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu |
if #6390 gets into master, I think an unbound gesture would be ok. |
You should be okay to just call core.restart, since this is being done in a script where you're already in the core queue anyway. |
I actually removed the gesture binding to ctrl+nvda+f4, so it is unbound now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. Are you able to comment on the testing that has been done on this? Has this been tested with dialogs open, or with addons installed? I think that the about dialog causes problems when trying to exit nvda, that might be to do with wx. It would be nice to know if this also had that behaviour.
I tested this both with the general settings and about dialogs open and I do not observe strange behavior. |
- PR #7169 : Editable div elements in Chrome are no longer have their label reported as their value while in browse mode. (Issue #7153) - PR #6396 : An unbound gesture (script_restart) has been added to allow NVDA to be restarted quickly. (PR #6396) - PR #6777 : A Braille setting has been added to "show messages indefinitely". (Issue #6669) - PR #7133 : Pressing end while in browse mode of an empty Microsoft Word document no longer causes a runtime error. (Issue #7009) - PR #6868 : The keyboard layout can now be set from the NVDA Welcome dialog. (Issue #6863) - PR #6813 : The names of "landmarks" are abbreviated in Braille (Issue #3975)
By default, ctrl+nvda+f4 is assigned, but we can consider removing this as well as change it to the current gesture for reloading plugins (ctrl+NVDA+f3).
Even though it is possible to restart NVDA using its desktop shortcut, this way of restarting appears to be much quicker and is a nice alternative for reloading plugins, which would allow for deprecating this as @jcsteh suggested in #6389. Furthermore, it works with portable copies.
The only thing I'm not sure about, do we just want to call core.restart, or use queueHandler.queueFunction(queueHandler.eventQueue,core.restart) as in gui.ExitDialog? I'm sure it's used there for a reason.