Add Keyboard layout setting to the Welcome dialog #6868
Conversation
Also: * Remove empty line at the end of the detail message. * Clean up translator comments. * Add mnemonics to the settings controls. Todo: * Use guiHelper. * Bring Keyboard settings dialog in line, i.e. add mnemonics there too.
|
I had a look at this to check the visual layout. Currently there is no gap (horizontally) between the label and |
|
Thank you. I'll move to guiHelper as part of this PR then. |
|
Just sprinkled some guiHelper on this dialog. |
source/gui/__init__.py
Outdated
| index = self.kbdNames.index(config.conf["keyboard"]["keyboardLayout"]) | ||
| self.kbdList.SetSelection(index) | ||
| except: | ||
| log.debugWarning("Could not set Keyboard layout list to current layout",exc_info=True) |
There was a problem hiding this comment.
log.debugWarning does not produce a sound in NVDA. If this is hit I would suggest that it is a serious enough error that users should be notified. I would propose changing this to log.error
There was a problem hiding this comment.
Updated my comment, debugWarning never produces a sound. error sounds are purposefully omitted from the release.
|
I copied the keyboard code from elsewhere. Arguably the welcome experience should be errorless from the user's perspective, even if under the hood everything's on fire. :) |
|
Understood, this will be the case in a release. However pre-release we want to know about problems as early as possible to have a chance to fix them prior to the release and RC versions. |
|
Do you suppose this also goes for the same log message when setting the layout from the settings dialog? That's where the code came from. |
…current value as an error.
|
Made it an error for the welcome dialog. Didn't touch the settings dialog though. |
- PR #7169 : Editable div elements in Chrome are no longer have their label reported as their value while in browse mode. (Issue #7153) - PR #6396 : An unbound gesture (script_restart) has been added to allow NVDA to be restarted quickly. (PR #6396) - PR #6777 : A Braille setting has been added to "show messages indefinitely". (Issue #6669) - PR #7133 : Pressing end while in browse mode of an empty Microsoft Word document no longer causes a runtime error. (Issue #7009) - PR #6868 : The keyboard layout can now be set from the NVDA Welcome dialog. (Issue #6863) - PR #6813 : The names of "landmarks" are abbreviated in Braille (Issue #3975)
For this addition I didn't rewrite the dialog to use guiHelper. As a consequence I'm not sure if it works out visually.
Fixes #6863.