Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userdocs: clarify whole word radio for speech dictionaries #11119

Merged

Conversation

ShubhamJain7
Copy link
Contributor

@ShubhamJain7 ShubhamJain7 commented May 6, 2020

Link to issue number:

fixes #10959

Summary of the issue:

User doc entry for whole word radio button was unclear.

Description of how this pull request fixes the issue:

Replaces current user doc entry with the suggestion made here.

Testing performed:

Known issues with pull request:

Change log entry:

Section: not necessary

Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShubhamJain7 and congrats on your first PR to NVDA! 🎉

@@ -1851,7 +1851,7 @@ The Add rule dialog also contains a checkbox to say whether or not you want the
NVDA ignores case by default).

Finally, a set of radio buttons allows you to tell NVDA whether your pattern should match anywhere, should only match if it is a complete word or should be treated as a "Regular expression".
Setting the pattern to match as a whole word means that the replacement will only be made if the pattern does not occur as part of a larger word; i.e. a character other than an alphanumeric character or an underscore (or no character at all) comes both immediately before and after the pattern.
Setting the pattern to match as a whole word means that the replacement will only be made if the pattern does not occur as part of a larger word. This condition is met if the characters immediately before and after the word are anything other than a letter, a number, or an underscore, or if there are no characters at all.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make translation of this file easier, we like each sentence to be on a new line. Could you split this line please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShubhamJain7

@feerrenrut feerrenrut merged commit 4e58029 into nvaccess:master May 6, 2020
@nvaccessAuto nvaccessAuto added this to the 2020.1 milestone May 6, 2020
@feerrenrut feerrenrut modified the milestones: 2020.1, 2020.2 May 6, 2020
@ShubhamJain7 ShubhamJain7 deleted the wholeWordClarificationInUserGuide branch May 15, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Guide: Clarification of Whole word radio button in 12.2.1. Speech dictionaries
3 participants