-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move exit dialog to submodule #13498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanbudd
added a commit
that referenced
this pull request
Mar 17, 2022
seanbudd
force-pushed
the
moveExitDialogToSubmodule
branch
from
March 17, 2022 06:35
fb2e9cc
to
467f814
Compare
This comment was marked as outdated.
This comment was marked as outdated.
seanbudd
force-pushed
the
moveExitDialogToSubmodule
branch
from
March 17, 2022 08:19
467f814
to
196b55d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
feerrenrut
added
the
conceptApproved
Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
label
Mar 18, 2022
seanbudd
requested review from
feerrenrut
and removed request for
michaelDCurran
March 18, 2022 06:19
feerrenrut
approved these changes
Mar 22, 2022
lukaszgo1
suggested changes
Mar 22, 2022
feerrenrut
suggested changes
Mar 23, 2022
feerrenrut
approved these changes
Mar 24, 2022
Co-authored-by: Łukasz Golonka <lukasz.golonka@mailbox.org>
seanbudd
force-pushed
the
moveExitDialogToSubmodule
branch
from
March 24, 2022 06:19
f60dfb4
to
a840171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conceptApproved
Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
When working on #13488, the exitDialog was lengthened, and probably should be moved to its own submodule file.
Description of how this pull request fixes the issue:
Moves and lints
ExitDialog
and_ExitAction
fromgui.__init__
intogui.exit
.Testing strategy:
git show ea52996ae9a3ae7a2a536d5298bce9d8595e24be --color-moved
git show ea2c04119
git show 196b55dc8 --ignore-cr-at-eol
Known issues with pull request:
None
Change log entries:
For Developers
Code Review Checklist: