Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exit dialog to submodule #13498

Merged
merged 4 commits into from
Mar 24, 2022
Merged

Move exit dialog to submodule #13498

merged 4 commits into from
Mar 24, 2022

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Mar 17, 2022

Link to issue number:

None

Summary of the issue:

When working on #13488, the exitDialog was lengthened, and probably should be moved to its own submodule file.

Description of how this pull request fixes the issue:

Moves and lints ExitDialog and _ExitAction from gui.__init__ into gui.exit.

Testing strategy:

  • Review the move commit with git show ea52996ae9a3ae7a2a536d5298bce9d8595e24be --color-moved
  • Review linting manually git show ea2c04119
  • Review the CRLF change with git show 196b55dc8 --ignore-cr-at-eol
  • Run NVDA and opening the exit dialog
  • Ensure Disable logging in secure mode #13488 isn't reintroduced

Known issues with pull request:

None

Change log entries:

For Developers

- ``gui.quit`` has been deprecated for removal in 2023.1. (#13498)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@seanbudd seanbudd marked this pull request as ready for review March 17, 2022 06:38
@seanbudd seanbudd requested a review from a team as a code owner March 17, 2022 06:38
@AppVeyorBot

This comment was marked as outdated.

@AppVeyorBot

This comment was marked as outdated.

@feerrenrut feerrenrut added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Mar 18, 2022
@seanbudd seanbudd self-assigned this Mar 18, 2022
@seanbudd seanbudd requested review from feerrenrut and removed request for michaelDCurran March 18, 2022 06:19
source/gui/exit.py Show resolved Hide resolved
source/gui/exit.py Outdated Show resolved Hide resolved
source/gui/exit.py Outdated Show resolved Hide resolved
@seanbudd seanbudd marked this pull request as draft March 23, 2022 00:36
@seanbudd seanbudd marked this pull request as ready for review March 23, 2022 02:16
source/gui/__init__.py Outdated Show resolved Hide resolved
source/gui/exit.py Outdated Show resolved Hide resolved
Co-authored-by: Łukasz Golonka <lukasz.golonka@mailbox.org>
@seanbudd seanbudd merged commit 14a9499 into master Mar 24, 2022
@seanbudd seanbudd deleted the moveExitDialogToSubmodule branch March 24, 2022 06:50
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants