Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Georgian (ka) documentation files #14252

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

CyrilleB79
Copy link
Collaborator

@CyrilleB79 CyrilleB79 commented Oct 14, 2022

Link to issue number:

https://groups.io/g/nvda-translations/message/3107

Summary of the issue:

English copies of user guide and change log have been added by mistake in SVN repo 'ka' folder (revision 70163 in SVN SRT repo). However, the Georgian do not plan to translate change log for now. And also not immediately user guide.
Today, these files have landed in the beta branch of NVDA. Unfortunately, adding files in SVN SRT allows to add new translations to beta, but removing them does not allow to remove the translation files.

Description of user facing changes

Remove Georgian (ka) documentation files (user doc + change log) as per translators request.

Description of development approach

Removed the files as well as in SRT repo.

Testing strategy:

N/A

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review October 16, 2022 19:59
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner October 16, 2022 19:59
@CyrilleB79 CyrilleB79 requested review from seanbudd and removed request for a team October 16, 2022 19:59
@seanbudd seanbudd merged commit 7aed56f into nvaccess:beta Oct 24, 2022
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Oct 24, 2022
@seanbudd seanbudd modified the milestones: 2023.1, 2022.4 Oct 24, 2022
@seanbudd
Copy link
Member

I have run the translation update script that runs on friday. It seems like these changes were safe.

@CyrilleB79 CyrilleB79 deleted the removeKaDoc branch November 23, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants