Fix text paragraph navigation speech #16145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @Adriani90 |
seanbudd
approved these changes
Feb 11, 2024
Nael-Sayegh
pushed a commit
to Nael-Sayegh/nvda
that referenced
this pull request
Feb 15, 2024
Closes nvaccess#16143 Summary of the issue: NVDA reports roles incorrectly when navigating using P quickNav Description of user facing changes Fixed speech so that p quickNav command behaves as expected. Description of development approach A quick investigation shows that this is the behavior of speech.speakTextInfo(info, reason=OutputReason.QUICKNAV) as called in browseMode.py:216. I didn't change that in textNav PR. This makes sense for other QuickNav commands. For example on that page if you press B, you get: Open global navigation menu Button Note that the word button goes in the end. If you stumble upon the same button via Control+Up/Down then the speech is Button Open global navigation menu So since text paragraph navigation is more similar to caret navigation in the sense that it navigates to text that might contain different roles, I propose to change to reason=OutputReason.CARET for text paragraph navigation as it seems to fix this issue.
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
Closes nvaccess#16143 Summary of the issue: NVDA reports roles incorrectly when navigating using P quickNav Description of user facing changes Fixed speech so that p quickNav command behaves as expected. Description of development approach A quick investigation shows that this is the behavior of speech.speakTextInfo(info, reason=OutputReason.QUICKNAV) as called in browseMode.py:216. I didn't change that in textNav PR. This makes sense for other QuickNav commands. For example on that page if you press B, you get: Open global navigation menu Button Note that the word button goes in the end. If you stumble upon the same button via Control+Up/Down then the speech is Button Open global navigation menu So since text paragraph navigation is more similar to caret navigation in the sense that it navigates to text that might contain different roles, I propose to change to reason=OutputReason.CARET for text paragraph navigation as it seems to fix this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #16143
Summary of the issue:
NVDA reports roles incorrectly when navigating using P quickNav
Description of user facing changes
Fixed speech so that p quickNav command behaves as expected.
Description of development approach
A quick investigation shows that this is the behavior of
speech.speakTextInfo(info, reason=OutputReason.QUICKNAV)as called inbrowseMode.py:216. I didn't change that in textNav PR.This makes sense for other QuickNav commands. For example on that page if you press B, you get:
Note that the word button goes in the end. If you stumble upon the same button via
Control+Up/Downthen the speech isSo since text paragraph navigation is more similar to caret navigation in the sense that it navigates to text that might contain different roles, I propose to change to
reason=OutputReason.CARETfor text paragraph navigation as it seems to fix this issue.Testing strategy:
Tested via test case provided in the issue.
Known issues with pull request:
N/A
Code Review Checklist: