-
-
Notifications
You must be signed in to change notification settings - Fork 164
WIP: Feat/which key descriptions #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Feat/which key descriptions #334
Conversation
a8267fb
to
60b99af
Compare
@kristijanhusak this should work. I need some confirmation on the descriptions I added |
60b99af
to
b28f385
Compare
Descriptions look fine, I just don't know if |
Hm, it doesn't look like that is possible via If nothing is declared for |
Ok, lets add it. I think it will be more useful if users know the context, especially if they override some of the |
These mappings are really starting to complicate. Lets hold on this for a bit, I'll rewrite it today so it's more readable and testable. I'm worried we will break something with these changes. |
Absolutely. It's special cases galore. Didn't want to introduce any breaking changes, that's why I did it this way. Ideally, all the mappings have the same format. Right now there is ~5 different ways to do it |
And as can be seen with the help overlay, things are already starting to break |
b28f385
to
3186ac3
Compare
new PR is #352 |
closes #314
TODO