Skip to content

Which-key descriptions #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jgollenz
Copy link
Contributor

sorry, botched the old branch

closes #314

@jgollenz jgollenz mentioned this pull request Jun 25, 2022
3 tasks
org_agenda_schedule = m.action('agenda.set_schedule'),
org_agenda_filter = m.action('agenda.filter'),
org_agenda_show_help = m.action('org_mappings.show_help'),
org_agenda_later = m.action('agenda.advance_span', { args = { 1 }, { opts = { desc = 'org later' } } }),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all the actions which have args, you need to pass opts on the same table. Currently you are nesting opts an additional table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's because I was copy-pasting from the ones that have no args. My bad, will fix.

@jgollenz jgollenz force-pushed the feat/which-key-descriptions branch from 162523a to de5a160 Compare June 26, 2022 21:23
@jgollenz jgollenz marked this pull request as ready for review June 26, 2022 21:25
Copy link
Member

@kristijanhusak kristijanhusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kristijanhusak kristijanhusak merged commit 07d0e00 into nvim-orgmode:master Jun 27, 2022
@jgollenz jgollenz mentioned this pull request Jul 31, 2022
3 tasks
@jgollenz jgollenz deleted the feat/which-key-descriptions branch August 10, 2022 16:15
gzagatti pushed a commit to gzagatti/orgmode that referenced this pull request Oct 19, 2022
SlayerOfTheBad pushed a commit to SlayerOfTheBad/orgmode that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add desc to orgmode keymap
2 participants