Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nwjs master #26

Closed
wants to merge 1 commit into from
Closed

nwjs master #26

wants to merge 1 commit into from

Conversation

onlyfish79
Copy link

No description provided.

@rogerwang rogerwang closed this Jun 29, 2016
rogerwang pushed a commit that referenced this pull request Sep 7, 2016
@jollycopper
[Android] Implement back key functionality in download manager
ade34bb 
On tablet, the back key already works, due to the browser caching a
navigation history. This CL implements the same thing on phones, by
caching a backstack history in download activity.

BUG=642030

Review-Url: https://codereview.chromium.org/2271583006
Cr-Commit-Position: refs/heads/master@{#414616}
(cherry picked from commit f324214)

Review URL: https://codereview.chromium.org/2295583002 .

Cr-Commit-Position: refs/branch-heads/2840@{#26}
Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}
rogerwang pushed a commit that referenced this pull request Dec 5, 2016
@bokand
Disable overlay scrollbars on ChromeOS
420142c 
The feature launch has been pushed back to M57.

BUG=307091

Review-Url: https://codereview.chromium.org/2513763002
Cr-Commit-Position: refs/heads/master@{#433207}
(cherry picked from commit 5cc17a0)

Review URL: https://codereview.chromium.org/2519013002 .

Cr-Commit-Position: refs/branch-heads/2924@{#26}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
Fix gtk theme regression introduced in 477aca4
367cd55 
Turns out we do need to explicitly clear the border images. This bug is
visible when you hover a toolbar button.

BUG=682940

Review-Url: https://codereview.chromium.org/2639423005
Cr-Commit-Position: refs/heads/master@{#445130}
(cherry picked from commit 7e2b5c1)

Review-Url: https://codereview.chromium.org/2645423002 .
Cr-Commit-Position: refs/branch-heads/2987@{#26}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
@miu-chromium
MediaRouter: Cache MediaRoutesObserver queries to prevent ext wake-ups
ea43cd3 
Resolved a performance issue where the Media Router component extension
was being woken-up each time a new tab was opened. The solution is to
cache route list updates so that the registration of new observers does
not force the extension to wake-up to report on something we can cache
browser-side. (This is the same as what is already being done for the
MediaSinksObservers.)

BUG=621246
TEST=Ran chrome with --enable-logging=stderr --vmodule=media_router_mojo_impl=1 to confirm extension wake-ups do not happen when opening new tabs.

Review-Url: https://codereview.chromium.org/2735493002
Cr-Commit-Position: refs/heads/master@{#454769}
(cherry picked from commit 34e86af)

Review-Url: https://codereview.chromium.org/2728293003 .
Cr-Commit-Position: refs/branch-heads/3029@{#26}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
Remove explicit -fomit_frame_pointer from ARM 32-bit builds.
3dcba7c 
-fomit_frame_pointer causes the assembly generated from SkEdge::setLine
to trigger a CPU errata in ARM A12/A17 devices, so we are temporarily
removing the flag until the toolchain can be fixed to avoid that.

Revert this when issue 711784 is resolved.

BUG=710131, 706654, 711784

Review-Url: https://codereview.chromium.org/2820803003
Cr-Commit-Position: refs/heads/master@{#464832}
(cherry picked from commit bec4450)

Review-Url: https://codereview.chromium.org/2819373002 .
Cr-Commit-Position: refs/branch-heads/3071@{#26}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Incrementing VERSION to 61.0.3163.12
217bd1a 
TBR=dimu@chromium.org

Change-Id: I93ef20411460a5115a4bd2987e00551198fe715b
Reviewed-on: https://chromium-review.googlesource.com/584936
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#26}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
Merge:Fix media element position on MediaDocument
31058f8 
The element should be centered
Adding back media/media-document-audio-repaint.html which is accidentally removed.
And rebaseline the text expectation so it can capture future regressions.

BUG=760484
TBR=wangxianzhu@chromium.org,mlamouri@chromium.org

(cherry picked from commit f628f1c)

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If7fded84745f1a6a04feab9a7b6c3d237b08c301
Reviewed-on: https://chromium-review.googlesource.com/646526
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499149}
Reviewed-on: https://chromium-review.googlesource.com/650835
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#26}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
OpenURL after bookmark dismissal to prevent race condition with BVC.
f146826 
In the new iOS bookmark ui, there was a race condition between dismissal
of bookmarks and switch of BVC when opening urls with incognito state
changed.  This CL fixes the bug by moving the openURL command to the
completion handler of bookmarkBrowser's dismissal when needed.

Bug: 772378
Change-Id: I177186baf04ba069d5307aeee4dcc4b64c4ac92d
Reviewed-on: https://chromium-review.googlesource.com/711895
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Marti Wong <martiw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#508672}(cherry picked from commit d36976a)
Reviewed-on: https://chromium-review.googlesource.com/722542
Reviewed-by: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#26}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
@mounirlamouri
Media Engagement: add metrics for time to load and time to lookup.
2200cdd 
Bug: 800758
Change-Id: Iea3614bd17563ef0106be267e5f597a79c23bec0
Reviewed-on: https://chromium-review.googlesource.com/874690
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530477}(cherry picked from commit c7d8bcf)
Reviewed-on: https://chromium-review.googlesource.com/880702
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#26}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
Incrementing VERSION to 66.0.3359.10
19c3602 
TBR=dimu@chromium.org

Change-Id: Ia48cb2d80fbd53bb68bbab9cb31e594ba1bce855
Reviewed-on: https://chromium-review.googlesource.com/950324
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#26}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@ywh233
[CRD iOS] Allow setup instruction cells to dynamically grow
034b798 
We got some reports from people using smaller phone and language with
longer words that the host setup instruction page has broken layout.
Basically cells are overlapping and texts are not fully shown.

This happens because we hardcoded the height of each cell. It's almost
impossible to get row height autolayout working with UICollectionVC, so
I reimplemented the page using UITableViewController.

Bug: 830877
Change-Id: I3f748a0409599eec09d5895fa324fbb5dc6ab68b
Reviewed-on: https://chromium-review.googlesource.com/1011630
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550807}(cherry picked from commit 7a8df9d)
Reviewed-on: https://chromium-review.googlesource.com/1012792
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#26}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
media: make the buffer_id in stream_buffer_manager consistent
1f30ec7 
The buffer_id is passed through Mojo as uint64, so we should refer to
the buffer_id throughout the code consistently as uint64_t.

BUG=832772
TBR=wuchengli

Change-Id: Ib6f260c4242e8c68510903cefcc997bf7a6bbd4d
Reviewed-on: https://chromium-review.googlesource.com/1073213
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561854}(cherry picked from commit f4f94d4)
Reviewed-on: https://chromium-review.googlesource.com/1076848
Cr-Commit-Position: refs/branch-heads/3440@{#26}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
@marcinwiacek
M69:fix for displaying ContentSettingException in 1 Settings screen path
6307484 
This patch is fixing change made with the
https://chromium-review.googlesource.com/c/chromium/src/+/1097408.

Before patch: ContentSettingException permissions are not displayed.

After patch: ContentSettingException are visible.

Affected path: Settings->Site Settings->(setting)->(exception site)

BUG=865032

Change-Id: I35dffa8c071fae4f4e76c69850b542b747dc493e
Reviewed-on: https://chromium-review.googlesource.com/1145434
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Original-Commit-Position: refs/heads/master@{#577135}(cherry picked from commit 97d5a24)
Reviewed-on: https://chromium-review.googlesource.com/1147160
Reviewed-by: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#26}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
@SujieZhu
[Local card migration] Add billing customer number in request
5254715 
Add billing customer number in the migration request.

TBR=mathp@chromium.org

Bug: 879681
Change-Id: Ia474eda34bc62982e724318f4048ecee6571cc14
Reviewed-on: https://chromium-review.googlesource.com/1198763
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#587931}(cherry picked from commit 2b01138)
Reviewed-on: https://chromium-review.googlesource.com/1204470
Cr-Commit-Position: refs/branch-heads/3538@{#26}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
Chrome OS: allow scrolling on the Error screen.
3e47f6b 
TBR=alemate@chromium.org

(cherry picked from commit e33d6c0)

Bug: 895000
Change-Id: I2a561a784e013e7d175ba31c5415b82c67d1bb59
Reviewed-on: https://chromium-review.googlesource.com/c/1279385
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599470}
Reviewed-on: https://chromium-review.googlesource.com/c/1281173
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#26}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Nov 10, 2018
Chrome OS: allow scrolling on the Error screen.
9a58929 
TBR=alemate@chromium.org

(cherry picked from commit e33d6c0)

(cherry picked from commit 3e47f6b)

Bug: 895000
Change-Id: I2a561a784e013e7d175ba31c5415b82c67d1bb59
Reviewed-on: https://chromium-review.googlesource.com/c/1279385
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#599470}
Reviewed-on: https://chromium-review.googlesource.com/c/1281173
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/3578@{#26}
Cr-Original-Branched-From: 4226ddf-refs/heads/master@{#599034}
Reviewed-on: https://chromium-review.googlesource.com/c/1297600
Cr-Commit-Position: refs/branch-heads/3538@{#1041}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
Reland "[unified-consent] Fix official browser tests"
89972ed 
This is a reland of 44c85b6

Original change's description:
> [unified-consent] Fix official browser tests
> 
> The unified consent feature was not enabled in
> UnifiedConsentBrowserTest for official tests.
> This is fixed now.
> 
> Bug: 910523, 888527
> Change-Id: Ied1223b008f83c8c92cf471f90e8021606e25fda
> Reviewed-on: https://chromium-review.googlesource.com/c/1356960
> Commit-Queue: Thomas Tangl <tangltom@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#612678}(cherry picked from commit 3763198)
> Reviewed-on: https://chromium-review.googlesource.com/c/1358449
> Reviewed-by: Thomas Tangl <tangltom@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3626@{#9}
> Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

Bug: 910523, 888527
Change-Id: I653b0faf8b59e64020b91a5bab3ab565588a3214
Reviewed-on: https://chromium-review.googlesource.com/c/1361221
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#26}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
Offer users an option to delete card from local if uploading failed
bbb07a2 
If uploading of a card failed, in the feedback dialog, we will show
a string 'invalid' and a trash can button. If the user clicks the button,
that card will be deleted from browser and will disappear in the
feedback dialog. If all invalid cards are deleted in the dialog, the
dialog will be updated to the 'finished' state.

If all cards failed, we will not show the "View cards button".

Uploaded screenshots in the bug (comment #10 and comment #26).

Using TBR because this merge had a conflict and needed to fix manually:
TBR=estade@chromium.org,tobiasjs@chromium.org,bsep@chromium.org,mahmadi@chromium.org

(cherry picked from commit 26874dc)

Bug: 913150
Change-Id: Iae7780027932ac530bcb2f0c643be1ec94d1f334
Reviewed-on: https://chromium-review.googlesource.com/c/1314129
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614193}
Reviewed-on: https://chromium-review.googlesource.com/c/1369941
Cr-Commit-Position: refs/branch-heads/3626@{#234}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
@toji
Removed XRDevice interface
b593337 
This changes the entry point into the WebXR APIs, as described
by the latest spec changes. It makes the concept of which physical
piece of hardware is being used implicit. The CL is unfortunately
large, but that's almost entirely due to the number of tests that the
change affects.

Bug: 916299
Change-Id: I32f2acec810761bbddd1f6df6e8ca91673dd381e
Reviewed-on: https://chromium-review.googlesource.com/c/1383393
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626199}(cherry picked from commit 94e08cd)
Reviewed-on: https://chromium-review.googlesource.com/c/1440907
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#26}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
@danbeam
WebUI Dark Mode: re-enable dark mode for User Manager
d5212ec 
I accidentally disabled it in https://crrev.com/c/1509494, as I thought
that CL would only affect print preview.

R=lgrey@chromium.org
BUG=940656

Change-Id: Ia839482f2e8b8dd115ea2f2db1424ce7ad98210d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516616
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#26}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onlyfish79 @rogerwang