Fix crash of `chrome.app.window.create(url, option)` when missing `option` argument #9

ghostoy · 2016-03-15T07:00:31Z

No description provided.

…tion`

…s://codereview.chromium.org/2249353002/ ) Reason for revert: I'll revert r413430 and its dependent CLs because r413430 caused issue 642072. The problem is that we cannot simply remove blink::shutdown because the following scenario can happen: 1) blink::shutdown is not called. Workers are still running. 2) RenderThreadImpl gets destructed. MessageLoop gets destructed. 3) The workers may access the RenderThreadImpl and MessageLoop. To fix the problem, we need to call ProcessDied() and forcibly kill the renderer process at the end of RenderThreadImpl::Shutdown(). Original issue's description: > Stop calling blink::shutdown > > RenderThreadImpl::Shutdown has been trying to shut down Blink and V8 gracefully, > but the graceful shutdown has caused tons of use-after-free bugs > (and many engineers has spent lots of time fixing ordering issues around the shutdown). > > As discussed in blink-dev@ (https://groups.google.com/a/chromium.org/d/topic/blink-dev/kk4VX0xRB7I/discussion) > and platform-architecture-dev@ (https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/Zc12k91NTFk/discussion), > there is no reason we have to shut down the renderer gracefully. > It's just causing use-after-free bugs and wasting performance. > Hence, this CL stops calling blink::shutdown, which had been > shutting down *some things* in Blink and V8 gracefully. > (Remember that blink::shutdown hadn't been shutting down everything; > a lot of objects in Blink and V8 had already been left as is without getting destructed.) > > Ideally we should just call ProcessDied() at an earlier stage of > RenderThreadImpl::Shutdown(), but I'd like to defer the change to a separate CL. > > BUG=639244 > > Committed: https://crrev.com/01cb51d26b17923ed2b5c3b59566f0fc9aed74ae > Cr-Commit-Position: refs/heads/master@{#413430} TBR=jochen@chromium.org,esprehn@chromium.org,torne@chromium.org,tzik@chromium.org BUG=639244 Review-Url: https://codereview.chromium.org/2312593002 Cr-Commit-Position: refs/heads/master@{#416494} (cherry picked from commit 19a7c51) Review URL: https://codereview.chromium.org/2315573003 . Cr-Commit-Position: refs/branch-heads/2840@{#163} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}

BUG=662503 Review-Url: https://codereview.chromium.org/2503543003 Cr-Commit-Position: refs/heads/master@{#433259} (cherry picked from commit 0d9dfef) Review URL: https://codereview.chromium.org/2516913002 . Cr-Commit-Position: refs/branch-heads/2924@{#9} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}

gcc has a bug in __attribute__ ((tls_model ("initial-exec"))) on arm. This patch undoes the TLS optimization on arm-gcc. BUG=682840 TEST=threadlocal_heap_ works as expected; CreateCacheIfNecessary() was only called a few times in a reasonably long benchmark. (cherry picked from commit 07dcf42) Review-Url: https://codereview.chromium.org/2640263003 Cr-Original-Commit-Position: refs/heads/master@{#445109} Cr-Commit-Position: refs/branch-heads/2987@{#9} Cr-Branched-From: ad51088-refs/heads/master@{#444943}

webkitdropzone is a prefixed version of the dropzone HTML global attribute. dropzone failed to gain traction among browser vendors, and only Blink and WebKit implement prefixed versions. Therefore, dropzone is being removed from the HTML specification in whatwg/html#2402 The following LayoutTests, which depended on webkitdropzone, have been rewritten to use event listeners. These tests cover other drag-and-drop functionality that we still want covered. * fast/events/dropzone-001 -> fast/dnd/dropEffect-for-effectAllowed * fast/events/dropzone-002 -> fast/dnd/dropEffect-for-image * fast/events/dropzone-003 -> fast/dnd/dropEffect-for-link * fast/events/dropzone-004 -> fast/dnd/dropEffect-for-file The followng LayoutTests have been removed, because they do not cover additional functionality that we still need. * fast/events/dropzone-005 -> only covers dropzone-specific code * fast/dnd/file-drop-on-webkitdropzone-element.html -> redundant with fast/dnd/file-drag-drop-on-page.html * http/tests/dnd/file-drop-on-webkitdropzone-element.html -> redundant with fast/dnd/file-drag-drop-on-page.html BUG=688943 Review-Url: https://codereview.chromium.org/2720463002 Cr-Commit-Position: refs/heads/master@{#454488} (cherry picked from commit 798a0d0) Review-Url: https://codereview.chromium.org/2729353002 . Cr-Commit-Position: refs/branch-heads/3029@{#9} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}

Cr-Commit-Position: refs/branch-heads/3071@{#9} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

changes: (1) When entering the tablet mode, the status area tray will always show the rotation lock auto or locked. (2) For system tray menu, the locked state is divided into two states: landscape and portrait. crbug.com/704923 #9 shows the UI implementation. TBR=oshima@chromium.org BUG=704923 TEST=tested on device Review-Url: https://codereview.chromium.org/2846883006 Cr-Commit-Position: refs/heads/master@{#468448} (cherry picked from commit 0eb3a02) Review-Url: https://codereview.chromium.org/2859663003 . Cr-Commit-Position: refs/branch-heads/3071@{#363} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

This reverts commit 1b60006. Reason for revert: Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash. Failing build (chromeos-side waterfall): https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205 Stack (from running manually with chrome --mash on Linux): [60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created. #0 0x7f06a03468bc base::debug::StackTrace::StackTrace() #1 0x7f06a036a121 logging::LogMessage::~LogMessage() #2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance() #3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl() #4 0x55f1834066ad chromeos::ShowLoginWizard() #5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize() #6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() #7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks() #13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize() #14 0x7f069d9e0b57 content::BrowserMain() #15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run() #16 0x7f06a0890d39 service_manager::Main() #17 0x7f069e1e7384 content::ContentMain() #18 0x55f182e8132f ChromeMain #19 0x7f069454af45 __libc_start_main #20 0x55f182e81194 <unknown> Original change's description: > Listen to changes to touch input devices > > In https://codereview.chromium.org/2964823002 the OobeDisplayChooser > started using the DeviceDataManager to look for touchscreen devices when > searching for a good primary display to use during OOBE. > > On device cold boot the DeviceDataManager has not yet found any > touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely > due to lower level systems not being fully initialized). > > This CL make LoginDisplayHostImpl an observer of changes to connected > touchscreen devices, re-triggering the OobeDisplayChooser when the > DeviceDataManager is notified of the connected touchscreens. This > overcomes the timing issues on cold boot. > > Bug: 738885 > Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd > Reviewed-on: https://chromium-review.googlesource.com/569958 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487007} TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 0cd134a) Bug: 738885 Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4 Reviewed-on: https://chromium-review.googlesource.com/574731 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#487191} Signed-off-by: Bernie Thompson <bhthompson@google.com> Reviewed-on: https://chromium-review.googlesource.com/575149 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#623} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}

…chset #9 id:160001 of https://codereview.chromium.org/2964823002/ ) Reason for revert: A follow up fix for a race condition on cold boot was reverted in https://chromium-review.googlesource.com/c/574731/. With only this patch the functionality is broken in the user facing scenario. The code state without either this cl or the follow up is better than with only this cl. Original issue's description: > Remove confusing keyboard test & inspect input device > > In order to make the decision for when to trigger the OOBE display > chooser less confusing for end users I'm removing the keyboard check. > Instead an explicit remora requisition check is used to limit the > effects. > > BUG=738885 > > Review-Url: https://codereview.chromium.org/2964823002 > Cr-Commit-Position: refs/heads/master@{#485019} > Committed: https://chromium.googlesource.com/chromium/src/+/c923b817665a649b4e18243116c31c68404af7dd TBR=jdufault@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=738885 (cherry picked from commit 8a2f3aa) Review-Url: https://codereview.chromium.org/2977293002 Cr-Original-Commit-Position: refs/heads/master@{#487262} Signed-off-by: Bernie Thompson <bhthompson@google.com> Change-Id: I18e13b36eddfb29352e0a261086984f3d8b611aa Reviewed-on: https://chromium-review.googlesource.com/575523 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#633} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}

This is a reland of c140538 Original change's description: > [vr] Restore opacity when transient elements are shown again. > > We'd previously set opacity to 0.0 when hiding elements in the > transience manager which makes it tricky to see them when they come > back. With this change, we inform the manager of the desired "opacity > when visible" and it will restore elements to that opacity when > shown again. > > Bug: None > Change-Id: I1a941c3032c35adab5afed17a8afc60bd41230f5 > Reviewed-on: https://chromium-review.googlesource.com/582069 > Commit-Queue: Ian Vollick <vollick@chromium.org> > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488788} TBR=cjgrant@chromium.org, vollick@chromium.org (cherry picked from commit c2485c4) Bug: 747633 Change-Id: I340ed94f61f016243dc4495d687cab1d58ea2e67 Reviewed-on: https://chromium-review.googlesource.com/582529 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488833} Reviewed-on: https://chromium-review.googlesource.com/582967 Cr-Commit-Position: refs/branch-heads/3163@{#9} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

TBR=govind@chromium.org Change-Id: I3096b54381dbecc4539d171c8154eab6f82a7827 Reviewed-on: https://chromium-review.googlesource.com/648260 Reviewed-by: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#9} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

TBR=dimu@chromium.org Change-Id: Idd2f94bc8583250171b4a8af4b5bafdc4abe8c86 Reviewed-on: https://chromium-review.googlesource.com/720559 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#9} Cr-Branched-From: adb61db-refs/heads/master@{#508578}

TBR=dimu@chromium.org Change-Id: Id45f8884c5f8fca6d13eed88c3da6f313e23fb88 Reviewed-on: https://chromium-review.googlesource.com/877027 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#9} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}

TBR=dimu@chromium.org Change-Id: I86b735348a7946412b26225bd0a48a8c14cb3e2c Reviewed-on: https://chromium-review.googlesource.com/947840 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#9} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}

Building the protobuf based on Input from extension API: 1) Machine name 2) OS information (x86/x64) 3) OS User 4) Chrome Profile and its extensions/plugins Other information that is stored in Chrome. 1) OS Information (Platform name and its version) 2) Browser version/channel. 3) Current profile ID based on its path 4) All policies affect the current profile. Please note that only one profile will be added into the report. Bug: 832896 Change-Id: I703ff554932388611c9839473b7dcadcf0cac3c1 Reviewed-on: https://chromium-review.googlesource.com/986946 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Marc-André Decoste <mad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550596}(cherry picked from commit 614a826) Reviewed-on: https://chromium-review.googlesource.com/1013341 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#9} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}

Removed some code that can simply rely on the Blink PictureInPictureController and made use of the DisplayType() in WMPI. Bug: None Change-Id: I7f6aac46cdd99c8a35d9ae95e1e3024e11f54960 Reviewed-on: https://chromium-review.googlesource.com/1069214 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#561745}(cherry picked from commit 376a94c) Reviewed-on: https://chromium-review.googlesource.com/1074827 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#9} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}

BUG=865977 TEST=Covered by unit test Change-Id: I444981ec98241d2a355d23d9711a961010a292c3 Reviewed-on: https://chromium-review.googlesource.com/1144628 Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576947}(cherry picked from commit 098f2ae) Reviewed-on: https://chromium-review.googlesource.com/1146086 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#9} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}

TBR=amineer@chromium.org Change-Id: I4bf9d0c87e26039f953e96055370b63caa905cde Reviewed-on: https://chromium-review.googlesource.com/1200869 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#9} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}

Original CL (uploaded as patchset 1): https://chromium-review.googlesource.com/c/chromium/src/+/1260491 Revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/1277577 Fix for reland: To ensure that no unnecessary network requests are made, I used a fake DeviceSync implementation for browser_tests, which I included in patchset 2. Original CL description: This CL enables several multi-device flags by default. This resulted in lots of broken tests, so this CL also fixes those broken tests. Instant Tethering is enabled via Finch flags; however, Finch does not immediately enable/disable features. Instead, when a user logs in, a Finch configuration is downloaded and is applied the next time the user logs in. Thus, to ensure that these features are available during OOBE, this CL overrides multi-device feature experiments during the first run. On subsequent logins, the Finch feature list will be applied. Bug: 884066, 894882 Change-Id: I879b903762f605d93eb6c9b1c709e0a4313903ef TBR: asvitkine@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1279067 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Jeremy Klein <jlklein@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599432}(cherry picked from commit b2868aa) Reviewed-on: https://chromium-review.googlesource.com/c/1279361 Cr-Commit-Position: refs/branch-heads/3578@{#9} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

The unified consent feature was not enabled in UnifiedConsentBrowserTest for official tests. This is fixed now. Bug: 910523, 888527 Change-Id: Ied1223b008f83c8c92cf471f90e8021606e25fda Reviewed-on: https://chromium-review.googlesource.com/c/1356960 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612678}(cherry picked from commit 3763198) Reviewed-on: https://chromium-review.googlesource.com/c/1358449 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#9} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

Revert "[unified-consent] Fix official browser tests" This reverts commit 44c85b6. Reason for revert: <INSERT REASONING HERE> Original change's description: > [unified-consent] Fix official browser tests > > The unified consent feature was not enabled in > UnifiedConsentBrowserTest for official tests. > This is fixed now. > > Bug: 910523, 888527 > Change-Id: Ied1223b008f83c8c92cf471f90e8021606e25fda > Reviewed-on: https://chromium-review.googlesource.com/c/1356960 > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#612678}(cherry picked from commit 3763198) > Reviewed-on: https://chromium-review.googlesource.com/c/1358449 > Reviewed-by: Thomas Tangl <tangltom@chromium.org> > Cr-Commit-Position: refs/branch-heads/3626@{#9} > Cr-Branched-From: d897fb1-refs/heads/master@{#612437} TBR=tangltom@chromium.org Change-Id: Ifda419362b527ef0567a4a283542a772389a3261 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910523, 888527 Reviewed-on: https://chromium-review.googlesource.com/c/1359306 Reviewed-by: Abdul Syed <abdulsyed@google.com> Cr-Commit-Position: refs/branch-heads/3626@{#15} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

This is a reland of 44c85b6 Original change's description: > [unified-consent] Fix official browser tests > > The unified consent feature was not enabled in > UnifiedConsentBrowserTest for official tests. > This is fixed now. > > Bug: 910523, 888527 > Change-Id: Ied1223b008f83c8c92cf471f90e8021606e25fda > Reviewed-on: https://chromium-review.googlesource.com/c/1356960 > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#612678}(cherry picked from commit 3763198) > Reviewed-on: https://chromium-review.googlesource.com/c/1358449 > Reviewed-by: Thomas Tangl <tangltom@chromium.org> > Cr-Commit-Position: refs/branch-heads/3626@{#9} > Cr-Branched-From: d897fb1-refs/heads/master@{#612437} Bug: 910523, 888527 Change-Id: I653b0faf8b59e64020b91a5bab3ab565588a3214 Reviewed-on: https://chromium-review.googlesource.com/c/1361221 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#26} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

Removes the HttpFallbackPenalty and the defunct PLM reported histograms. Replaces them with a new histogram that is updated with the navigation restart penalty for each type of Preview status. Bug: 923256 Change-Id: I41ff9b27cf9434b2cd06982cb54ecf23ea5be0d0 Reviewed-on: https://chromium-review.googlesource.com/c/1424138 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#625996}(cherry picked from commit ece21eb) Reviewed-on: https://chromium-review.googlesource.com/c/1437927 Reviewed-by: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#9} Cr-Branched-From: e510299-refs/heads/master@{#625896}

This patch allows to show the web ui, such as settings and reminder in the embedded Assistant view. Currently limits the size to be the same as the embedded UI. TBR=xiyuan@chromium.org,xiaohuic@chromium.org Bug: 924624 Test: manual Change-Id: I5b40bf3cbae45484d5dd45b5a6c79bfcaf65bb38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504047 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#638971}(cherry picked from commit b1202ba31176720cd6943444114aca50e7eb9442) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513042 Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#9} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}

chrome-tpm and others added 3 commits March 7, 2016 15:12

Publish DEPS for Chromium 49.0.2623.87

14be212

nwjs master

35715c5

Fix crash of chrome.app.window.create(url, option) when missing `op…

41b2fa5

…tion`

rogerwang force-pushed the nw13 branch 13 times, most recently from 9a310ac to c4d99d5 Compare March 21, 2016 12:21

rogerwang force-pushed the nw13 branch 9 times, most recently from b5bfa94 to 802e375 Compare March 29, 2016 15:19

rogerwang force-pushed the nw13 branch 5 times, most recently from 85c8bc4 to 53ac9e0 Compare April 7, 2016 02:48

rogerwang force-pushed the nw13 branch 5 times, most recently from 114f968 to f581ec8 Compare April 13, 2016 11:56

ghostoy closed this Nov 7, 2016

GnorTech pushed a commit that referenced this pull request Apr 26, 2017

Incrementing VERSION to 59.0.3071.7

ab9a152

Cr-Commit-Position: refs/branch-heads/3071@{#9} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix crash of `chrome.app.window.create(url, option)` when missing `option` argument #9

Fix crash of `chrome.app.window.create(url, option)` when missing `option` argument #9

ghostoy commented Mar 15, 2016

Fix crash of chrome.app.window.create(url, option) when missing option argument #9

Fix crash of chrome.app.window.create(url, option) when missing option argument #9

Conversation

ghostoy commented Mar 15, 2016

Fix crash of `chrome.app.window.create(url, option)` when missing `option` argument #9

Fix crash of `chrome.app.window.create(url, option)` when missing `option` argument #9