[win] fix menubar background #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerwang
force-pushed
the
nw15
branch
3 times, most recently
from
0fc8753
to
1920370
Compare
Menubar background should be consistent with the theme by the system. On Windows, we use `COLOR_MENU` for the background color for menubar. fixed nwjs/nw.js#4851
ghostoy
force-pushed
the
issue-4851-fix2
branch
2 times, most recently
from
34a389a
to
95b96da
Compare
rogerwang
force-pushed
the
nw15
branch
2 times, most recently
from
db31318
to
b33fad2
Compare
|
will rebase it for nw16 |
rogerwang
pushed a commit
that referenced
this pull request
Sep 7, 2016
R=tsergeant@chromium.org BUG=640893 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2284463002 Cr-Commit-Position: refs/heads/master@{#414643} (cherry picked from commit ad86c21) Review URL: https://codereview.chromium.org/2289013002 . Cr-Commit-Position: refs/branch-heads/2840@{#27} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}
rogerwang
pushed a commit
that referenced
this pull request
Dec 5, 2016
…tchset #6 id:100001 of https://codereview.chromium.org/2468863002/ ) Reason for revert: Regressed crbug.com/647393. Original issue's description: > scheduler: Re-enable timer throttling for hidden frames > > Turn hidden timer throttling back now that the issue with Gmail pop-ups > not working has been resolved by https://codereview.chromium.org/2272773002/. > > This patch also fixes a timer throttling related rebase error in a > previous patch and adds new layout test that cover out-of-view timer > and requestAnimationFrame throttling. > > Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_Lhz8THHk2Q > > BUG=616519,647393 > > Committed: https://crrev.com/1688130897aed95d32e3904a6aa10384414fbefe > Cr-Commit-Position: refs/heads/master@{#432642} TBR=kinuko@chromium.org,ojan@chromium.org,ojan@google.com BUG=616519,647393 Review-Url: https://codereview.chromium.org/2511283002 Cr-Commit-Position: refs/heads/master@{#433061} (cherry picked from commit 32461cc) Review URL: https://codereview.chromium.org/2520953002 . Cr-Commit-Position: refs/branch-heads/2924@{#27} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech
pushed a commit
that referenced
this pull request
Jan 29, 2017
Previously we scale favicons or media artwork images to the ideal size regardless of their original size. This increases the memory usage as we create another copy of the original image and the size will also be increased if the original image size is smaller than the ideal size. In this CL, if the original image size is smaller than the ideal size, we will reuse the original image and won't scale it anymore. BUG=682701 Review-Url: https://codereview.chromium.org/2641133004 Cr-Commit-Position: refs/heads/master@{#445147} (cherry picked from commit c3a5799) Review-Url: https://codereview.chromium.org/2649173002 . Cr-Commit-Position: refs/branch-heads/2987@{#27} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang
pushed a commit
that referenced
this pull request
Mar 11, 2017
It defaults to _ and we use . in the code. BUG=695306 Review-Url: https://codereview.chromium.org/2727233006 Cr-Commit-Position: refs/heads/master@{#454648} (cherry picked from commit 3e367b7) Review-Url: https://codereview.chromium.org/2738493003 . Cr-Commit-Position: refs/branch-heads/3029@{#27} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
SyncSessionsWebContentsRouter accesses an instance of the TabContentsSyncedTabDelegate directly on Android when it should use SyncedTabDelegateAndroid instead. This change fixes that. R=zea@chromium.org BUG=711847 Review-Url: https://codereview.chromium.org/2823843003 Cr-Commit-Position: refs/heads/master@{#464963} (cherry picked from commit 66da2b8) Review-Url: https://codereview.chromium.org/2824063002 . Cr-Commit-Position: refs/branch-heads/3071@{#27} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
This CL adds a check and a test for this case. TBR=vollick@chromium.org (cherry picked from commit 4056f74) Bug: 747816 Change-Id: I937a3ec0b1cc99cdd75da05f2c0f79ea59423e6a Reviewed-on: https://chromium-review.googlesource.com/581724 Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488975} Reviewed-on: https://chromium-review.googlesource.com/585287 Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#27} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
On newer ARC-enabled devices, the Chrome versions of the default apps that were replaced by their corresponding ARC apps won't be installed. TBR=rdevlin.cronin@chromium.org, elijahtaylor@chromium.org, skym@chromium.org, khmel@chromium.org BUG=744719 TEST=Create a new account on an ARC device and notice no Chrome versions of the apps Play Books, Play Movies, and Play Music. Only ARC apps of these apps are available. (cherry picked from commit 9ef29e0) Change-Id: I698d74b8bc26c51623c8d6d2e5b054bbe1423666 Reviewed-on: https://chromium-review.googlesource.com/620027 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499211} Reviewed-on: https://chromium-review.googlesource.com/651106 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#27} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
SavePendingPasswordViewController sets itself as a delegate to NSComboBox. When the save password bubble moves to the promo state, the controller is destroyed synchronously. The views in the bubble still exist for some time and the combobox may ping the delegate. TBR=vasilii@chromium.org (cherry picked from commit b0e8a53) Bug: 774033 Change-Id: I1131806e32aec7f038d94f1e58b72655092b73ed Reviewed-on: https://chromium-review.googlesource.com/718208 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508691} Reviewed-on: https://chromium-review.googlesource.com/723021 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#27} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
…ms from browser process. This makes it easier to isolate them in UMA tools. Intentionally do not support a backward compatible path. With M65 going to beta shortly this avoids an intermediate mess. TBR=fdoray@chromium.org, robliao@chromium.org, sdefresne@chromium.org, alexmos@chromium.org (cherry picked from commit 5b74dcb) Bug: 803019 Change-Id: I10c05b4dc5dfed18a7d26255676af980ce233eaa Reviewed-on: https://chromium-review.googlesource.com/870390 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530481} Reviewed-on: https://chromium-review.googlesource.com/880966 Cr-Commit-Position: refs/branch-heads/3325@{#27} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
TBR=dimu@chromium.org Change-Id: I56b5ef2774f944dd33af3bef87d40b3506534bec Reviewed-on: https://chromium-review.googlesource.com/950363 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#27} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
DownloadManagerTabHelper does not work without delegate, so make sure that DownloadManagerCoordinator is created before DownloadManagerTabHelper. Previously DownloadManagerCoordinator was created in viewDidLoad which is called after all Tab Helpers are attached to the restored tabs. TBR=eugenebut@google.com (cherry picked from commit 464ebff) Bug: 832210 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id5bcbec42b0723007aef4d8a25a065cb30238484 Reviewed-on: https://chromium-review.googlesource.com/1011182 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550731} Reviewed-on: https://chromium-review.googlesource.com/1014476 Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#27} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
We should use uint64_t for buffer_id and stream_id consistently throughout the code; otherwise we would have truncation problems on 32-bit platforms. BUG=832772 TEST=Run capture_unittests on Dru and Soraka. TBR=wuchengli Change-Id: Ida3a841a6ed6be8c978bb03363dbbf475ed92b02 Reviewed-on: https://chromium-review.googlesource.com/1074507 Reviewed-by: Ricky Liang <jcliang@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562115}(cherry picked from commit 25b36ea) Reviewed-on: https://chromium-review.googlesource.com/1076907 Cr-Commit-Position: refs/branch-heads/3440@{#27} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5905949b5fc6359af193a0e09d384ec9d6256a50 Reviewed-on: https://chromium-review.googlesource.com/1147318 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#27} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
In certain cases (e.g., when the device is offline), network quality estimator (NQE) may emit negative network quality values. This CL adds logic to handle those values: In the manager class, if the estimate changes from an unknown value to a know value, then the client is always notified. In the tracker class, handle notifications that indicate that a metric is unavailable. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2c82914e51c649a6b1b2e9b21682ebd4a193b138 Bug: 878893 Reviewed-on: https://chromium-review.googlesource.com/1196105 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588109}(cherry picked from commit 6b79159) Reviewed-on: https://chromium-review.googlesource.com/1203452 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#27} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If040f9fe1c2d5001480fd53b3960a34da2f2fbf4 Reviewed-on: https://chromium-review.googlesource.com/c/1281343 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#27} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
When a simple disk_cache is in APP_CACHE mode eviction is disabled and access times do not need to be tracked. This means that it should be possible to perform read-only operations without triggering any index disk writes. This CL implements this optimization by making the following changes: * Avoid updating access times in APP_CACHE mode. * Avoid writing a clean index to disk when closing the backend. * Avoid dirtying the index when a size update does not make a change. * Avoid dirtying the index when opening an entry that is in the index. * Avoid dirtying the index when dooming an entry not in the index. With these changes its possible to use simple disk_cache to perform read-only operations in cache_storage without any index writes. Bug: 905351 Change-Id: I8eed0a72ed166e7b1b3623a7f4c17f7cec7f96d4 Reviewed-on: https://chromium-review.googlesource.com/c/1351539 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612934}(cherry picked from commit 8a7e962) Reviewed-on: https://chromium-review.googlesource.com/c/1361322 Reviewed-by: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#27} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
Bug: 916299 Change-Id: I533f0f9847892cdf2cdd5c49f9c7ba957c391298 Reviewed-on: https://chromium-review.googlesource.com/c/1437524 Commit-Queue: Brandon Jones <bajones@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Brandon Jones <bajones@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#626284}(cherry picked from commit 398ad14) Reviewed-on: https://chromium-review.googlesource.com/c/1440909 Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#27} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
The hotwordDisabled_ function was not defined as a property. As a result, the dspHotwordState dropdown, which uses hotwordDisabled_ to configure its disabled state, was always disabled. Fixed issue by defining hotwordDisabled_ as a property. (cherry picked from commit 202f2cdae9d938ea58d821c4047c8e5ee7115c49) Bug: b:125938368 Change-Id: Iff8bcdc77e67055d2dd6a47b76c5afcb49094446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495206 Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Eyor Alemayehu <eyor@google.com> Cr-Original-Commit-Position: refs/heads/master@{#639215} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516026 Cr-Commit-Position: refs/branch-heads/3729@{#27} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menubar background should be consistent with the theme by the
system. On Windows, we use
COLOR_MENUfor the background colorfor menubar.
fixed nwjs/nw.js#4851