Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High fidelity noise models for orbit determination #146

Conversation

ChristopherRabotin
Copy link
Member

@ChristopherRabotin ChristopherRabotin commented May 13, 2023

Effects

  • Replace md::ui module withmd::prelude.
  • Remove MDProcess: it was getting too complicated and is only used to run scenarios from TOML. This feature was never used and a new simpler Python based UI will be unveiled soon.
  • Remove the KfTrigger trait, thereby preventing custom implementations of a CKF to EKF trigger. Open issues for new features.
  • In an ODProcess, the EKF trigger is now an optional EkfTrigger structure. Usability wise, it does not change anything.
  • Add a constant noise model
  • Update the noise modeling in Ground Station
  • Pr/N0 noises for range and doppler

If this is a new feature or a bug fix ...

  • Yes, the branch I'm proposing to merge is called issue-xyz where xyz is the number of the issue.

If this change adds or modifies a validation case

  • Yes and:
    • I have coded up, or updated, an existing test case; and
    • I have provided a GMAT script which confirms the result(s); and
    • I have updated the VALIDATION.md file with the new error data between nyx and GMAT.
    • I will specify the version of GMAT used for the validation.

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
This simplifies the code quite a bit.

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch coverage: 94.06% and project coverage change: +65.12 🎉

Comparison is base (bae4921) 0.00% compared to head (0125897) 65.12%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #146       +/-   ##
===========================================
+ Coverage        0   65.12%   +65.12%     
===========================================
  Files           0      126      +126     
  Lines           0    32961    +32961     
===========================================
+ Hits            0    21465    +21465     
- Misses          0    11496    +11496     
Impacted Files Coverage Δ
src/cosmic/orbit.rs 72.95% <ø> (ø)
src/dynamics/spacecraft.rs 81.37% <ø> (ø)
src/io/mod.rs 57.22% <ø> (ø)
src/io/trajectory_data.rs 0.00% <ø> (ø)
src/md/mod.rs 0.00% <ø> (ø)
src/md/opti/convert_impulsive.rs 0.00% <ø> (ø)
src/md/opti/multipleshooting/altitude_heuristic.rs 90.27% <ø> (ø)
src/md/opti/multipleshooting/ctrlnodes.rs 73.22% <ø> (ø)
.../md/opti/multipleshooting/equidistant_heuristic.rs 0.00% <ø> (ø)
src/md/opti/multipleshooting/multishoot.rs 73.39% <ø> (ø)
... and 28 more

... and 88 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Also:
+ Remove obsolete files
+ Add monte carlo test to code coverage

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
@ChristopherRabotin ChristopherRabotin merged commit 9df435a into master May 15, 2023
@ChristopherRabotin ChristopherRabotin deleted the 88-high-fidelity-transponder-modeling-different-noise-models branch May 15, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interface: Python Kind: Improvement This is a proposed improvement Priority: high Status: Development Issue at Test Driven Development phase of the quality assurance process Topic: Orbit Determination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High fidelity transponder modeling (different noise models)
1 participant