Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Portuguese (Brazil) translation for support #1258

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

arferreira
Copy link
Contributor

Hey folks,
adding my main language, Portuguese from Brazil.

Let me know if I forget something.

Tks

README.md Outdated
@@ -21,7 +21,8 @@
<a href="docs/README.ja.md">日本語</a> |
<a href="docs/README.kr.md">한국어</a> |
<a href="docs/README.ru.md">Русский</a> |
<a href="docs/README.tr.md">Türkçe</a>
<a href="docs/README.tr.md">Türkçe</a> |
<a href="docs/README.pt-br.md">Português (Brasil)</a> |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this trailing pipe (|) be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goes unnoticed, thanks man.

@@ -0,0 +1,31 @@
<h3 align="center"><img src="assets/onefetch.svg" height="130px"></h3>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h3 align="center"><img src="assets/onefetch.svg" height="130px"></h3>
<h3 align="center"><img src="../assets/onefetch.svg" height="130px"></h3>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<p align="center">
<a href="https://crates.io/crates/onefetch"><img src="https://img.shields.io/crates/v/onefetch.svg" alt="cargo"></a>
<a href="https://github.com/o2sh/onefetch/actions"><img src="https://github.com/o2sh/onefetch/workflows/CI/badge.svg" alt="Build Status"></a>
<a href="https://onefetch.dev"><img src="assets/language-badge.svg"></a>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="https://onefetch.dev"><img src="assets/language-badge.svg"></a>
<a href="https://onefetch.dev"><img src="../assets/language-badge.svg"></a>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<a href="https://github.com/o2sh/onefetch/actions"><img src="https://github.com/o2sh/onefetch/workflows/CI/badge.svg" alt="Build Status"></a>
<a href="https://onefetch.dev"><img src="assets/language-badge.svg"></a>
<a href="https://github.com/o2sh/onefetch/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22"><img src="https://img.shields.io/github/issues/o2sh/onefetch/help%20wanted?color=green" alt="help wanted"></a>
<a href="./LICENSE.md"><img src="https://img.shields.io/badge/license-MIT-blue.svg"></a>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="./LICENSE.md"><img src="https://img.shields.io/badge/license-MIT-blue.svg"></a>
<a href="../LICENSE.md"><img src="https://img.shields.io/badge/license-MIT-blue.svg"></a>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<a href="https://onefetch.dev"><img src="assets/language-badge.svg"></a>
<a href="https://github.com/o2sh/onefetch/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22"><img src="https://img.shields.io/github/issues/o2sh/onefetch/help%20wanted?color=green" alt="help wanted"></a>
<a href="./LICENSE.md"><img src="https://img.shields.io/badge/license-MIT-blue.svg"></a>
<img src="assets/msrv-badge.svg">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="assets/msrv-badge.svg">
<img src="../assets/msrv-badge.svg">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<img src="assets/msrv-badge.svg">
</p>

<img src="assets/screenshot-1.png" align="right" height="250px">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="assets/screenshot-1.png" align="right" height="250px">
<img src="../assets/screenshot-1.png" align="right" height="250px">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


Ele detecta automaticamente licenças de código aberto a partir de textos e fornece ao usuário informações valiosas como distribuição de código, alterações pendentes, número de dependências (por gerenciador de pacotes), principais contribuidores (por número de commits), tamanho no disco, data de criação, LOC (linhas de código), etc.

<img src="assets/screenshot-2.png" align="right" height="250px">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="assets/screenshot-2.png" align="right" height="250px">
<img src="../assets/screenshot-2.png" align="right" height="250px">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


A partir de agora, onefetch oferece suporte a mais de [100 linguagens de programação diferentes](https://onefetch.dev); se a linguagem não estiver disponível: abra um issue e o suporte para a linguagem será adicionado.

Contribuições são muito bem-vindas! Consulte [CONTRIBUTING](CONTRIBUTING.md) para obter mais informações.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Contribuições são muito bem-vindas! Consulte [CONTRIBUTING](CONTRIBUTING.md) para obter mais informações.
Contribuições são muito bem-vindas! Consulte [CONTRIBUTING](../CONTRIBUTING.md) para obter mais informações.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@o2sh
Copy link
Owner

o2sh commented Jan 20, 2024

Thanks lot for your contribution @arferreira 🎉

Do you think it would be possible to make it in Portuguese, not just Brazilian Portuguese, to reach a wider audience?

@arferreira
Copy link
Contributor Author

Thanks lot for your contribution @arferreira 🎉

Do you think it would be possible to make it in Portuguese, not just Brazilian Portuguese, to reach a wider audience?

Yes, I do. We can remove the Brazil, most of the time the words are the same the difference would be in the accent.
What do you think?

docs/README.pt-br.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -21,7 +21,8 @@
<a href="docs/README.ja.md">日本語</a> |
<a href="docs/README.kr.md">한국어</a> |
<a href="docs/README.ru.md">Русский</a> |
<a href="docs/README.tr.md">Türkçe</a>
<a href="docs/README.tr.md">Türkçe</a> |
<a href="docs/README.pt-br.md">Português (Brasil)</a>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="docs/README.pt-br.md">Português (Brasil)</a>
<a href="docs/README.pt-br.md">Português</a>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to README.pt.md

Co-authored-by: Ossama Hjaji <ossama-hjaji@live.fr>
@o2sh
Copy link
Owner

o2sh commented Mar 24, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@o2sh o2sh added the stale label Mar 24, 2024
@spenserblack
Copy link
Collaborator

Anything preventing merging?

@arferreira
Copy link
Contributor Author

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@o2sh what is missing? not sure if I understand.

@o2sh
Copy link
Owner

o2sh commented Jun 2, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@o2sh o2sh added the stale label Jun 2, 2024
@o2sh o2sh closed this Jun 9, 2024
@spenserblack
Copy link
Collaborator

Going to reopen this as I still think it's valid.

Pinging @o2sh, did @arferreira's changes resolve your feedback?

@spenserblack spenserblack reopened this Jun 9, 2024
@spenserblack spenserblack removed the stale label Jun 9, 2024
@o2sh
Copy link
Owner

o2sh commented Jun 11, 2024

The last time I checked, it matched the Google translation almost perfectly.

@spenserblack
Copy link
Collaborator

Oh, I see. Now that you mention it, I see that some things appear to be translated literally.

It could be a similar situation as #631 (comment). @arferreira, it would help if you described how the translation was made 🙂

Obrigado!

@arferreira
Copy link
Contributor Author

Hey folks, I'm a native speaker lol but anyway just lemme know what's similar from a translator or something wrong?

@spenserblack
Copy link
Collaborator

spenserblack commented Jun 11, 2024

I can't say if anything is wrong (I don't know enough Portuguese to know if anything is wrong 😆). Just confirming how the translation was made. For example, did you:

  • Translate this all manually?
  • Start with a machine translation for a "rough draft" and then read the machine translation to make adjustments?

I don't think it's necessarily a problem, but if the translation looks too similar to a machine translation it could be a sign that only a machine translation was done, and no human review. But it's perfectly possible that Google Translate can translate so well that it ends up looking the same as a human, native translator.

One thing to think about is that, sometimes when translating, it's very easy to be literal and sound very machine-like. For example, once I tried to translate some text to English and I realized I was sounding very robotic, because I was scared of changing the original author's intent. My translation didn't have any interpretation, and instead just re-wrote the text in English. If your translation is very similar to a machine translation, maybe ask yourself "how would I write this in my words?" instead of trying to match the original content as closely as possible.

But if you firmly believe that this translation already sounds natural to native speakers, let us know 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants